-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build for node 6 and node 8 #15
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
node 8 seems to make some symlinks that conda-build doesn't like. Will investigate what's up there. |
@minrk I restarted the travis build and it passed. Can you restart Appveyor? |
The appveyor failures seem to be real. I haven't had a chance to figure out what's going wrong. |
@minrk If you can add me to the feedstock team, I can see if I spot anything on Windows. Looking at the errors, it looks like a PATH error or a |
@willingc great idea! Open a PR adding yourself to the maintainers list and I'll merge it. The change takes a while to propagate (it can be hours). |
Thanks @minrk. |
npm install -g <folder> does a symlink on node 8 for some reason
can’t seem to do two-line scripts in meta.yaml on Windows
@willingc I had a look at this again and I think I might know what's up. The first thing I had to change is that |
Cool. Looks great and tests pass 🎉 I'll let you merge when you are done tweaking the Windows install commands. |
Latest pass was erroneous because it didn't run on Windows. Had to poke it to try again. Hopefully it will work. The previous build failed, apparently because it simply wasn't running more than one line of bld.bat, which is strange. |
script: npm install -g . | ||
number: {{ build }} | ||
string: "node{{node_major}}_{{ build}}" | ||
script: npm pack; npm install -g {{name}}-{{version}}.tgz # [not win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For multiline scripts, one can do this.
put nodeX in the build string
closes #14