Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build for node 6 and node 8 #15

Merged
merged 4 commits into from
Apr 23, 2018
Merged

build for node 6 and node 8 #15

merged 4 commits into from
Apr 23, 2018

Conversation

minrk
Copy link
Member

@minrk minrk commented Jan 8, 2018

put nodeX in the build string

closes #14

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@minrk
Copy link
Member Author

minrk commented Jan 13, 2018

node 8 seems to make some symlinks that conda-build doesn't like. Will investigate what's up there.

@willingc
Copy link
Contributor

willingc commented Mar 1, 2018

@minrk I restarted the travis build and it passed. Can you restart Appveyor?

@minrk
Copy link
Member Author

minrk commented Mar 1, 2018

The appveyor failures seem to be real. I haven't had a chance to figure out what's going wrong.

@willingc
Copy link
Contributor

willingc commented Mar 2, 2018

@minrk If you can add me to the feedstock team, I can see if I spot anything on Windows.

Looking at the errors, it looks like a PATH error or a / instead of \.

@minrk
Copy link
Member Author

minrk commented Mar 2, 2018

@willingc great idea! Open a PR adding yourself to the maintainers list and I'll merge it. The change takes a while to propagate (it can be hours).

@willingc
Copy link
Contributor

willingc commented Mar 2, 2018

Thanks @minrk.

npm install -g <folder> does a symlink on node 8 for some reason
can’t seem to do two-line scripts in meta.yaml on Windows
@minrk
Copy link
Member Author

minrk commented Mar 13, 2018

@willingc I had a look at this again and I think I might know what's up. The first thing I had to change is that npm install -g <path> creates a symlink instead of doing a normal install with npm 5.x. This appears to be a non-optional change (annoying). So what I ended up doing was running npm pack to repackage a tarball, then do npm install -g <tarball> to do a normal install. I think on Windows, my two-line script doesn't work so it's only doing the pack and skipping the next step. The latest commit separates the build into bld.bat so both lines ought to be executed now.

@willingc
Copy link
Contributor

Cool. Looks great and tests pass 🎉 I'll let you merge when you are done tweaking the Windows install commands.

@minrk
Copy link
Member Author

minrk commented Mar 13, 2018

Latest pass was erroneous because it didn't run on Windows. Had to poke it to try again. Hopefully it will work.

The previous build failed, apparently because it simply wasn't running more than one line of bld.bat, which is strange.

@minrk minrk merged commit 4426ccf into conda-forge:master Apr 23, 2018
script: npm install -g .
number: {{ build }}
string: "node{{node_major}}_{{ build}}"
script: npm pack; npm install -g {{name}}-{{version}}.tgz # [not win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minrk minrk deleted the node-8 branch June 5, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node 8
4 participants