New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test with mambabuild #77
Conversation
…0, and conda-forge-pinning 2021.10.13.20.28.53
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This PR should not be merged, but exists to validate that mambabuild works as intended for a default build system |
@mariusvniekerk, what's the purpose of this PR? |
@beckermr requested that I use this one as a stress test before we roll out the new smithy with mambabuild |
cc @wolfv seems that Could that also just have been caused by the removal of the defaults channel here? |
Yeah this is a red flag for me that we have some latent bugs that need fixing before we roll out mambabuild. |
this circular dependency notification seems to come from Is there a circular dependency?
I will have a more in-depth look tomorrow. |
This package builds when mamba is not used, so something is happening there. |
Looking back on it, this feedstock passed two days ago without mamba: #76 AFAIK there has not been a release of any relevant packages for the build since then. So I do think somehow mamba is tripping a bug or has one. |
I am happy to look into this more tomorrow (quite later over here in Europe). Still unsure what's going on -- maybe there is some pre-processing that's missed in the mambabuild -- or maybe what Isuru just pushed will fix it, let's see! :) |
Sorry @wolfv! Not trying to push you at all. Just writing down my thinking for why this is odd. Get some sleep and thank you for all of the hard work! |
No worries, I am really curious about this one. It doesn't really look like a "mamba"-specific bug right now, but I need to investigate a bit more. |
It's not. It's a conda-build that I fixed a long time ago, but waiting for a conda-build release. |
This is where the error seems to come from: https://github.com/conda/conda-build/blob/13aa64b3701499215c80847e097945441c410135/conda_build/metadata.py#L286-L305 It may be an issue with cross-compilation ... I'll have a look tomorrow! We can release |
Something doesn't make sense though. Something about mamba is causing the build to hit this error again (as it did not a few days ago). That means it is shipping sufficiently different environments in the build to trigger the code path that conda did not. That in and of itself is a cause for concern. |
This line in master was removed in rerendering. https://github.com/conda-forge/ctng-compilers-feedstock/blob/master/.scripts/build_steps.sh#L15 |
There is also the defaults channel that's removed though |
Ahhh thanks @isuruf. Assuming this build passes then we should go ahead and switch over! |
Nicely found @isuruf |
…0, and conda-forge-pinning 2021.10.13.20.28.53
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)