Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for existing -ccbin / --compiler-bindir flag in NVCC_PREPEND_FLAGS #20

Open
jakirkham opened this issue Jun 8, 2023 · 0 comments

Comments

@jakirkham
Copy link
Member

jakirkham commented Jun 8, 2023

As a user can include their own -ccbin / --compiler-bindir flags that would conflict with our flags added to NVCC_PREPEND_FLAGS (see below), it would be good to add a check to only add our flags if they are not -ccbin / --compiler-bindir in NVCC_PREPEND_FLAGS

NVCC_PREPEND_FLAGS="${NVCC_PREPEND_FLAGS} -ccbin=${CXX}"

In the nvcc wrapper script, this was handled on this line. Though --compiler-bindir is not checked. So maybe that logic can be adapted and tweaked here.

Edit: Originally came up in PR ( conda-forge/gromacs-feedstock#17 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant