Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ppc64le for CUDA 10.2 #12

Merged
merged 8 commits into from
Jun 4, 2021
Merged

Conversation

leofang
Copy link
Member

@leofang leofang commented Jun 2, 2021

Close #6.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@leofang leofang requested a review from jakirkham as a code owner June 2, 2021 18:48
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The recipe license should not include the word "License".

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.10.1, and conda-forge-pinning 2021.06.02.13.20.38
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@leofang
Copy link
Member Author

leofang commented Jun 2, 2021

/usr/bin/which: no cuda-gdb in (/home/conda/feedstock_root/build_artifacts/cutensor_1622660207840/_build_env/bin:/home/conda/feedstock_root/build_artifacts/cutensor_1622660207840/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/bin:/opt/conda/condabin:/home/conda/feedstock_root/build_artifacts/cutensor_1622660207840/_build_env:/home/conda/feedstock_root/build_artifacts/cutensor_1622660207840/_build_env/bin:/home/conda/feedstock_root/build_artifacts/cutensor_1622660207840/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl:/home/conda/feedstock_root/build_artifacts/cutensor_1622660207840/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/bin:/opt/conda/bin:/opt/conda/condabin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/home/conda/bin)
Cannot determine CUDA_HOME: cuda-gdb not in PATH

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=332029&view=logs&j=9a864fd9-6c8f-52ca-79ce-2aa6dca1a1de&t=10fc5aa2-324e-5982-4c88-6b31fcab16b3&l=147

@jaimergp Is something wrong with nvcc's activate script on ppc64le?

@jaimergp
Copy link
Member

jaimergp commented Jun 3, 2021

The problem is more on the Docker image side. For some reason, /usr/local/cuda/bin is not on PATH, despite conda-forge/docker-images#181

See workarounds in https://github.com/conda-forge/openmm-feedstock/pull/55/files#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR23

@leofang
Copy link
Member Author

leofang commented Jun 3, 2021

Ah nice, thanks @jaimergp for pointer!

@leofang
Copy link
Member Author

leofang commented Jun 4, 2021

hmmm...The compiler flags work on x86-64 but not on ppc64le...

++ nvcc -Xcompiler -mno-float128 -I/home/conda/feedstock_root/build_artifacts/cutensor_1622774225568/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/include -L/home/conda/feedstock_root/build_artifacts/cutensor_1622774225568/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib -lcutensor contraction.cu -o contraction
+ error_log='/home/conda/feedstock_root/build_artifacts/cutensor_1622774225568/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/bin/../lib/gcc/powerpc64le-conda-linux-gnu/8.4.0/../../../../powerpc64le-conda-linux-gnu/bin/ld: contraction: hidden symbol `cudaLaunchKernel'\'' in /usr/local/cuda/bin/../targets/ppc64le-linux/lib/libcudart_static.a(libcudart_static.a.o) is referenced by DSO
/home/conda/feedstock_root/build_artifacts/cutensor_1622774225568/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/bin/../lib/gcc/powerpc64le-conda-linux-gnu/8.4.0/../../../../powerpc64le-conda-linux-gnu/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status'

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=332796&view=logs&j=9a864fd9-6c8f-52ca-79ce-2aa6dca1a1de&t=10fc5aa2-324e-5982-4c88-6b31fcab16b3&l=320

@leofang leofang added the automerge Merge the PR when CI passes label Jun 4, 2021
@github-actions github-actions bot merged commit 290c934 into conda-forge:master Jun 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@leofang leofang deleted the ppc64le branch June 4, 2021 03:37
@leofang
Copy link
Member Author

leofang commented Jun 4, 2021

@jaimergp Thanks again! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build for ppc64le
3 participants