Add extensions #19
Add extensions #19
Conversation
martinandersen
commented
May 10, 2018
•
martinandersen
commented
- Windows: add GSL and FFTW
- Linux/macOS: add DSDP (closes Possibly add DSDP5 support #2)
- Install CVXOPT header file
- Windows: add GSL and FFTW - Linux/macOS: add DSDP
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| - glpk | ||
| - suitesparse 4.5.6 # [not win] | ||
| - suitesparse 4.5.6|4.5.6.* # [not win] | ||
| - suitesparse 5.1.* # [win] |
There was a problem hiding this comment.
Could you please raise a conda-forge-pinning issue about pinning suitesparse globally?
There was a problem hiding this comment.
I'm not sure I understand. Does this have something to do with the suitesparse install_name on macOS? This was the reason for pinning a specific version.
There was a problem hiding this comment.
Basically conda-forge-pinning determines how things get pinned globally so that we don't need to hardcode them ourselves. So it would be good if it incorporated a sensible pinning for suitesparse. Raising the issue there would put adding this to the pinning list on other people's radar.
ref: https://conda-forge.org/docs/meta.html#pinning-packages
There was a problem hiding this comment.
Also please take a look at the .ci_support files that the re-rendering bot added. This will help give an idea as to how dependencies are handled now.
There was a problem hiding this comment.
|
@conda-forge-admin, please re-render. |
recipe/meta.yaml
Outdated
| @@ -24,20 +25,22 @@ requirements: | |||
| - setuptools | |||
| - blas 1.1 {{ variant }} | |||
| - openblas 0.2.20|0.2.20.* | |||
There was a problem hiding this comment.
We can drop the openblas pinning and just leave the dependency.
recipe/meta.yaml
Outdated
| - glpk | ||
| - suitesparse 4.5.6 # [not win] | ||
| - suitesparse 4.5.6|4.5.6.* # [not win] | ||
| - suitesparse 5.1.* # [win] | ||
|
|
||
| run: | ||
| - python | ||
| - blas 1.1 {{ variant }} | ||
| - openblas 0.2.20|0.2.20.* |
|
Should I go ahead and merge or should we wait for suitesparse to be pinned globally? |
|
@conda-forge-admin, please re-render. |
|
Feel free to merge once CI passes. It'll probably take a bit until we sort out the pinning issue. No need to block this on it. Just wanted us to get that work started. |
|
Thanks @martinandersen :) |
