Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove googleapis-common-protos pin #13

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Conversation

apmorton
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@apmorton apmorton requested review from bollwyvl and a team as code owners November 27, 2023 22:29
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@apmorton
Copy link
Contributor Author

For some reason this pin seems to be causing the following in our environment:

The following packages are incompatible
├─ dagster-gcp >=0.21.7,<1  is installable and it requires
│  └─ googleapis-common-protos !=1.57.0 *_1, which can be installed;
└─ googleapis-common-protos >=1.61.0  is not installable because it conflicts with any installable versions previously reported.

and the referenced fix has been merged a long time ago anyway.

@bollwyvl
Copy link
Contributor

@conda-forge-admin please rerender

@bollwyvl
Copy link
Contributor

@conda-forge-admin please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/dagster-libs-feedstock/actions/runs/7024428446.

@bollwyvl
Copy link
Contributor

Often a yak shave with the big FAANG packages as deps, buh: thanks for digging into this.

@bollwyvl bollwyvl merged commit d1c872e into conda-forge:main Nov 28, 2023
3 checks passed
@apmorton apmorton deleted the patch-1 branch November 28, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants