Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dask entry point #144

Closed

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Oct 21, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Attempting to address the issue outlined by comment ( conda-forge/distributed-feedstock#226 (comment) ).

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member Author

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/dask-core-feedstock/actions/runs/3298752595.

@jakirkham
Copy link
Member Author

Given we are still seeing issues with the dask entry point ( conda-forge/distributed-feedstock#226 (comment) ), proposing we drop it.

Thoughts @jrbourbeau? 🙂

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakirkham. I'm (unfortunately) able to reproduce. I'm not sure how dropping the dask entrypoint will help. Based on the conda-forge docs, I thought we needed to specify console_script entrypoints in the recipe.

From the docs on noarach Python packages it says

Only console_scripts entry points have to be listed in meta.yaml. Other entry points do not conflict with noarch and therefore do not require extra treatment.

We've included the dask console_scripts entrypoint here. I'm confused why the distributed entrypoints behind dask scheduler, etc. aren't working since they're not defined via console_scipts

@jakirkham
Copy link
Member Author

Charles observed we have the wrong entry point path. PR ( #146 ) addresses this. Though there is a question about whether we need to tweak it further

@jakirkham
Copy link
Member Author

Superseded by PR ( #146 )

@jakirkham jakirkham closed this Oct 25, 2022
@jakirkham jakirkham deleted the drop_dask_entry_point branch October 25, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants