-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop dask
entry point
#144
Drop dask
entry point
#144
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please re-render |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/dask-core-feedstock/actions/runs/3298752595. |
Given we are still seeing issues with the Thoughts @jrbourbeau? 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jakirkham. I'm (unfortunately) able to reproduce. I'm not sure how dropping the dask
entrypoint will help. Based on the conda-forge docs, I thought we needed to specify console_script
entrypoints in the recipe.
From the docs on noarach
Python packages it says
Only console_scripts entry points have to be listed in meta.yaml. Other entry points do not conflict with noarch and therefore do not require extra treatment.
We've included the dask
console_scripts
entrypoint here. I'm confused why the distributed
entrypoints behind dask scheduler
, etc. aren't working since they're not defined via console_scipts
Charles observed we have the wrong entry point path. PR ( #146 ) addresses this. Though there is a question about whether we need to tweak it further |
Superseded by PR ( #146 ) |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Attempting to address the issue outlined by comment ( conda-forge/distributed-feedstock#226 (comment) ).