Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop click from test/requires #148

Merged

Conversation

jakirkham
Copy link
Member

Now that click is a required dependency, there is no need to install it in test/requires. So drop it from there.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Now that `click` is a required dependency, there is no need to install
it in `test/requires`. So drop it from there.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham mentioned this pull request Oct 28, 2022
5 tasks
@jrbourbeau jrbourbeau added the automerge Merge the PR when CI passes label Oct 28, 2022
@jakirkham jakirkham mentioned this pull request Oct 28, 2022
5 tasks
@github-actions github-actions bot merged commit efe5569 into conda-forge:main Oct 28, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham jakirkham deleted the drop_click_test_req branch October 28, 2022 22:35
@jakirkham
Copy link
Member Author

Thanks James! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants