Migrate to python3.10 and apply patches. #58
Conversation
…nda-forge-pinning 2021.12.03.08.21.30
erykoff
requested review from
mariusvniekerk,
ocefpaf,
pmlandwehr and
scopatz
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| @@ -7,9 +7,12 @@ package: | |||
| source: | |||
| url: https://github.com/docker/docker-py/archive/{{ version }}.tar.gz | |||
| sha256: 0035772df94a86e8db02aac363393755584383aacf50d37b0d55ea817149e1f4 | |||
| patches: | |||
| - 0001-loosen-pywin32-pin.patch | |||
| - 0002-update-test-skips.patch | |||
There was a problem hiding this comment.
Are these upstream or upstream-able? If the former please add a link to the commit or PR that added them. If the latter than consider sending them upstream.
recipe/0001-loosen-pywin32-pin.patch
Outdated
| @@ -1,3 +1,4 @@ | |||
| Adapted from https://github.com/docker/docker-py/pull/2857/commits/2e8975698eb3bc36cb037e601ee798eace9bcc53 | |||
There was a problem hiding this comment.
Please add those to the recipe as a comment at the top of the patch line. Here they'll probably break the patching.
There was a problem hiding this comment.
Great point, I've moved the references. But it turns out you can put anything you want at the top of a patch file, I believe it's ignored until it hits the --- line.
There was a problem hiding this comment.
Ah. Yes! Still, we need to easily spot those during the next update to decide if we can drop them or not. So the best place is the recipe. Addition comments like, umerged, or merged and can be dropped next release also helps.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)This applies the proposed upstream patches from docker/docker-py#2857