Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows build #65

Merged
merged 51 commits into from
Feb 5, 2023
Merged

Add windows build #65

merged 51 commits into from
Feb 5, 2023

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Apr 1, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Add a windows build (closes #64)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@zklaus
Copy link
Contributor Author

zklaus commented Apr 1, 2021

@conda-forge-admin, please rerender

@zklaus zklaus changed the title Remove skip on windows Add windows build Apr 1, 2021
@zklaus
Copy link
Contributor Author

zklaus commented Apr 1, 2021

@conda-forge-admin, please rerender

@zklaus
Copy link
Contributor Author

zklaus commented Apr 1, 2021

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@zklaus
Copy link
Contributor Author

zklaus commented Dec 14, 2022

@conda-forge-admin, please rerender

@zklaus
Copy link
Contributor Author

zklaus commented Dec 14, 2022

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@zklaus
Copy link
Contributor Author

zklaus commented Jan 25, 2023

@conda-forge-admin, please rerender

@zklaus
Copy link
Contributor Author

zklaus commented Jan 25, 2023

@conda-forge-admin, please restart ci

@zklaus
Copy link
Contributor Author

zklaus commented Jan 25, 2023

@conda-forge-admin, please restart ci

@zklaus
Copy link
Contributor Author

zklaus commented Jan 26, 2023

@conda-forge-admin, please rerender

@zklaus
Copy link
Contributor Author

zklaus commented Feb 4, 2023

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits February 4, 2023 17:02
@zklaus zklaus marked this pull request as ready for review February 5, 2023 20:59
Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, @zklaus, amazing work! I looked through the patches and they look fine to me at a glance, though I don't feel qualified to assess them in detail. It's good enough for me that testing works.

@xylar
Copy link
Contributor

xylar commented Feb 5, 2023

@ocefpaf and @rokuingh, do you want to review or show @zklaus merge this?

@ocefpaf
Copy link
Member

ocefpaf commented Feb 5, 2023

@zklaus as @xylar already said, this is amazing! What an herculean effort! I'd love if @rokuingh could look at the patches and, if possible, upstream them. However, I'm OK merging this as-is b/c if you are the main user of this package you'll know pretty soon if it is OK or not.

PS: I'm stealing the honor of merging this now but I'll definitely buy you and @xylar a 🍺 and/or ☕ if we manage to meet in person.

@ocefpaf ocefpaf merged commit a660f86 into conda-forge:main Feb 5, 2023
@zklaus
Copy link
Contributor Author

zklaus commented Feb 6, 2023

Cheers, guys! Very happy to see this come along.

Re upstreaming, I have the patches in a branch against upstream at https://github.com/zklaus/esmf/tree/develop-windows. The commits should be largely orthogonal, i.e. easy to cherry-pick. I'll try to do PRs myself, but won't be mad at all if someone else gets to it first ;)

Re meeting in person, that's a great idea! You wouldn't happen to be in Vienna in late April?

@zklaus zklaus deleted the windows-build branch February 7, 2023 08:39
@ocefpaf
Copy link
Member

ocefpaf commented Feb 8, 2023

Re upstreaming, I have the patches in a branch against upstream at https://github.com/zklaus/esmf/tree/develop-windows. The commits should be largely orthogonal, i.e. easy to cherry-pick. I'll try to do PRs myself, but won't be mad at all if someone else gets to it first ;)

Awesome! I can try to send them if you are too busy.

Re meeting in person, that's a great idea! You wouldn't happen to be in Vienna in late April?

I no longer have an excuse to go to Vienna (EGU) b/c I'm not doing science anymore but I hope to be back. I'll keep you posted if I land there. If you are coming to SciPy in the USA please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a windows build
4 participants