Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v7.1.0r #10

Merged
merged 11 commits into from Mar 20, 2018
Merged

Release v7.1.0r #10

merged 11 commits into from Mar 20, 2018

Conversation

bekozi
Copy link
Contributor

@bekozi bekozi commented Mar 9, 2018

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • There are too few lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/meta.yaml Outdated

requirements:
build:
- python
- numpy
- esmf
- esmf ==7.1.0r
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do esmf {{ version }} here and below to avoid errors when updating the package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Pushed an update. Thanks for the review!

@bekozi
Copy link
Contributor Author

bekozi commented Mar 13, 2018

@ocefpaf Is there something going on with infrastructure? Am I missing something obvious with these recipes? 😖

@ocefpaf
Copy link
Member

ocefpaf commented Mar 13, 2018

Let's rerender and find out 😄

@conda-forge-admin, please rerender

@bekozi
Copy link
Contributor Author

bekozi commented Mar 13, 2018

SF is bad with tarballs/zips. Is it okay use use a git repo and tag?

Re-rendering seemed to help, so thank you!

@ocefpaf
Copy link
Member

ocefpaf commented Mar 13, 2018

SF is bad with tarballs/zips. Is it okay use use a git repo and tag?

That is fine for now. Do you have a plan to move away from sourceforge?

Re-rendering seemed to help, so thank you!

We will also need to refresh the CircleCI token. But before we do that I'd like to point this feedstock to @CJ-Wright, @justcalamari, and @isuruf in case they want to take a look at CircleCI and check if we can automate the token refresh using the bot.

@bekozi
Copy link
Contributor Author

bekozi commented Mar 13, 2018

move away from sourceforge

😧 That's the plan but who knows if/when that will happen...

@isuruf
Copy link
Member

isuruf commented Mar 13, 2018

Thanks @ocefpaf, "There are no deploy keys for this repository."

@ocefpaf
Copy link
Member

ocefpaf commented Mar 13, 2018

Thanks @ocefpaf, "There are no deploy keys for this repository."

@isuruf let me know if you want to experiment with this feedstock or if it is OK to issue the token update.

@bekozi sorry, we are using the fact that this one was not updated in a while to experiment with some new tech 😄

@bekozi
Copy link
Contributor Author

bekozi commented Mar 13, 2018

@bekozi sorry, we are using the fact that this one was not updated in a while to experiment with some new tech smile

No problem. Take your time. Always good to see it from the perspective of a guinea pig once in awhile. 😁

@CJ-Wright
Copy link
Member

@isuruf is that from the circle log? Is there a good way to access the log via program?

@isuruf
Copy link
Member

isuruf commented Mar 13, 2018

No, that's from the settings of this repo. You can use the github API at https://developer.github.com/v3/repos/keys/

@CJ-Wright
Copy link
Member

Is the division between things that don't have keys, and those that do or is there a third state of having keys that are out of date?

@bekozi bekozi mentioned this pull request Mar 13, 2018
@bekozi bekozi merged commit 1f22d31 into conda-forge:master Mar 20, 2018
@bekozi bekozi deleted the release-v7.1.0 branch March 20, 2018 23:38
@ocefpaf
Copy link
Member

ocefpaf commented Mar 21, 2018

Is the division between things that don't have keys, and those that do or is there a third state of having keys that are out of date?

FYI I just updated the token here. People needed this version to the uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants