Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.1 and pip #23

Merged
merged 14 commits into from
Apr 29, 2019
Merged

v0.3.1 and pip #23

merged 14 commits into from
Apr 29, 2019

Conversation

martindurant
Copy link
Contributor

@martindurant martindurant commented Apr 25, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@martindurant
Copy link
Contributor Author

@conda-forge-admin, please rerender

@martindurant martindurant mentioned this pull request Apr 25, 2019
@martindurant
Copy link
Contributor Author

@conda-forge-admin, please rerender

@martindurant
Copy link
Contributor Author

@msarahan , do you know what "RuntimeError: Setuptools downloading is disabled in conda build. Be sure to add all dependencies in the meta.yaml" means, what package it's trying to download?

@martindurant
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The requirements/ sections should be defined in the following order: build, host, run; instead saw: host, build, run.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@msarahan
Copy link
Member

@martindurant
Copy link
Contributor Author

But numpy is in host (for compiling) build and run too - where is it missing?

@msarahan
Copy link
Member

Things can also be "missing" if they are present, but don't match a constraint that's present in your requirements. Look in setup.py or requirements.txt. Does numpy requirement there match the one that conda is providing?

@martindurant
Copy link
Contributor Author

requirements.txt is pretty simple:

pandas>=0.19
numba>=0.28
numpy>=1.11
thrift>=0.11.0
six

and build says installing as below, only higher or matching versions of these

...
    cython:          0.29.7-py27he1b5a44_0    conda-forge
    numba:           0.41.0-py27h637b7d7_1000 conda-forge
    numpy:           1.9.3-py27he5ce36f_1209  conda-forge
    pandas:          0.23.4-py27h637b7d7_1000 conda-forge
    six:             1.12.0-py27_1000         conda-forge
    thrift:          0.11.0-py27hf484d3e_1001 conda-forge
...

recipe is now ("latest" should be fine for everything)

  build:
    - python
    - pip
    - setuptools
    - cython
    - numpy
    - pytest-runner
    - numba
    - thrift
    - pandas
    - {{ pin_compatible('numpy') }}
  host:
    - {{ compiler('c') }}
    - python
    - pandas
    - pip
    - setuptools
    - numpy
    - pytest-runner
    - numba
    - thrift

@msarahan
Copy link
Member

numpy>=1.11

and

numpy:           1.9.3-py27he5ce36f_1209  conda-forge

@martindurant
Copy link
Contributor Author

OK, that did it, sorry for the hassle @msarahan and thank you

@martindurant martindurant merged commit 09a0052 into conda-forge:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants