Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release v1.7.1 from upstream. #22

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

vitenti
Copy link
Contributor

@vitenti vitenti commented Feb 20, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@vitenti
Copy link
Contributor Author

vitenti commented Feb 20, 2024

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@vitenti
Copy link
Contributor Author

vitenti commented Feb 20, 2024

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/firecrown-feedstock/actions/runs/7978916180.

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new maintainer needs comment on this PR that they are ok being on the feedstock before it can be merged.

Also, conda-forge's bots will generate this PR for you if you wait long enough.

@mattkwiecien
Copy link

@beckermr I am ok with being added as a maintainer! Thanks.

@vitenti vitenti merged commit c65479a into conda-forge:main Feb 20, 2024
11 checks passed
@vitenti vitenti deleted the new_release_v1.7.1 branch February 20, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants