fmt.dll ends up in wrong directory on Windows

[robquant]

On Windows the shared library fmt.dll is installed in %CONDA_PREFIX%\Library\lib (as is the static lib fmt.lib). However, the canonical path for shared libs in conda environments is %CONDA_PREFIX%\Library\bin. Therefore the shared lib is not found when running a programm that is linked against it.

[tdegeus]

@robquant I'm not a Windows expert. Could you confirm that this fmtlib/fmt#1432 would fix the issue?

[tdegeus]

@robquant Also can you confirm if/that CMake also still knows where to look on Windows?

[robquant]

@tdegeus I tried your fix, but needed to make some changes to it: fmtlib/fmt#1437
With this the dll is copied to the right place and cmake is also able to link to it later.

[tdegeus]

Great @robquant !

It would be great @vitaut if you could release a new version if fmtlib/fmt#1437 is merged. The alternative would be to add patches to the feedstock here (e.g. #6 ), but given the number of commits since the last release this becomes a bit clumsy.

[tdegeus]

And thanks @robquant for the report, and the improvement of my PR.

[robquant]

Thanks @tdegeus for pointing me to the right place in the CMakeLists.txt!

[vitaut]

I'm currently working on putting together a new release and fmtlib/fmt#1437 can be part of it.

[tdegeus]

@robquant Can you confirm that this issue is fixed in version 6.1.0?

[robquant]

@tdegeus Yes, fmt.dll is now in the right place!