New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-branch, boost 1.78, python3.11, vtk 9.2, linux-aarch64, osx-arm64, occt 7.7, pcl 1.13 #78
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
For recipe:
Documentation on acceptable licenses can be found here. |
osx-arm:
linux-aarch64:
these two errors are caused by cross-compilation. win:
|
Thanks a lot for working on this! |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
For recipe:
Documentation on acceptable licenses can be found here. |
@wwmayer can you help with the windows issue? Is this due to the boost update? |
If I got it right then you have upgraded to boost 1.78 and now you run into a build failure when compiling LuxTools.cpp. Now boost/regex.hpp is also included in FreeCADBase and FreeCADApp. Apparently this compiles fine because the two libs are built before Raytracing.
Does adding it to FreeCAD/src/Mod/Raytracing/App/CMakeLists.txt solve the failure? |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
…nda-forge-pinning 2022.12.02.15.22.41
thanks for your help! the definition is included in the linker command: |
@wwmayer also adding the boost_libraries to the link-libraries didn't solve this issue. |
OK, if this doesn't help it could be a general problem with boost 1.78 and it may occur on other platforms too. I will try to compile this boost version locally on Linux and build FreeCAD with it. |
Using boost 1.78 on Linux works fine. But after re-reading the error message I realized the missing "LCTYPE" type. The line 200 in w32_regex_traits.hpp expects that Windows.h is already included but in fact it isn't. It may help to add |
thanks, I tried this with the last patch update. |
At the moment yes but in the future it may be used for other compilers, too. |
Still the same problem. Did I add the include at a wrong position? |
Oh, my bad. I just realized that for the Raytracing module we don't use the PCH (Pre-compiled header) option. But when looking at the code of LuxTools.cpp no regular expression are used. So, it would be fine to just remove the line |
|
@wwmayer it seems like the boost fix works only for enabled precompiled headers. Do you have any idea? |
@wwmayer can you have a look why your fix for boost 1.78 is not working when pch are disabled? |
What are the latest error messages? |
@wwmayer it's the boost error:
|
OK, it's still the same error as always. But for which source file does the compiler raise this error? |
@wwmayer the error occurs in TechDraw:
I guess that this error didn't occur if pch was enabled. But I am not sure about this. |
I cannot see a reason why it works with PCH enabled and why it fails when disabled. The compiler still complains about unknown identifiers and functions that are supposed to be added by including Windows.h. |
Thanks @wwmayer I will try to include windows.h via a patch. Maybe this works. |
@wwmayer The conclusion why it works with pch enabled was because we run into the other issue: and you fixed that with: Now with pch disabled we are stuck again with the boost/regex error. I really have no idea why it works for pch enabled but not with pch disabled.
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
with pch enabled compiling the problematic tech draw file seems to be working:
but the build fails somewhere else... @wwmayer can you try building freecad + boost 1.78 with pch disabled? |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.01.20.05.27.27
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.01.20.05.27.27
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.02.24.22.31.19
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.03.04.15.25.23
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)