Include pkgconfig in libglib #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmaarrfk
requested review from
ccordoba12,
isuruf,
jakirkham,
ocefpaf,
pkgw,
scopatz and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin pleas rerender |
|
I'll read the linked issue later. Just please don't merge before that. |
xhochy
requested changes
Oct 28, 2020
There was a problem hiding this comment.
Looked through the issue and still think that this PR shouldn't go in. libglib is all about the runtime parts of glib. The build-time things should stay in glib (which would better be called libglib-dev in future). This is in line with the current discussions in conda-forge/cfep#39
|
Got it. Thanks. I guess the naming has-been changing and for. Awhile lib meant "build time dependency" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: conda-forge/harfbuzz-feedstock#57
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)