Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in __osx spec #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typo in __osx spec #12

wants to merge 1 commit into from

Conversation

maresb
Copy link

@maresb maresb commented Feb 17, 2024

I randomly noticed that the variable here was MACOS_DEPLOYMENT_TARGET instead of MACOSX_DEPLOYMENT_TARGET set here. I'm not bumping a build number because I think the default should handle it, so I think there's no change to the build.

Also, I'm pretty confused what's going on since I only see this being built for linux-64. But hey, I noticed this and thought I should point it out.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@timfel
Copy link
Contributor

timfel commented Feb 19, 2024

Thanks! I need to update the build scripts anyway, and this finally prods me to fix and enable the macos builds :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants