Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is this skipped on windows now? #47

Closed
scopatz opened this issue Jun 29, 2020 · 6 comments
Closed

Why is this skipped on windows now? #47

scopatz opened this issue Jun 29, 2020 · 6 comments

Comments

@scopatz
Copy link
Member

scopatz commented Jun 29, 2020

@CJ-Wright - It seems like this is skipped now

@CJ-Wright
Copy link
Member

I'm not certain why that change was made (despite me making it). Feel free to add it back. (I presume that that version had issues building for windows, but I can't be certain).

@jakirkham
Copy link
Member

I think we rely on Graphviz to build Windows binaries for us, which we repackage. While they built one for 2.38.0, I don't believe they built one for 2.40.1. Since building from source on Windows has been non-trivial, I think we came to a consensus to push out 2.40.1 for the platforms that support it (skipping Windows).

At this point, I think we would need to build Graphviz from source on Windows. Though they did add CMake support ( #11 ), which should make it easier (if someone is wanting to pursue that 😉)

@jarrodmillman
Copy link

jarrodmillman commented Aug 22, 2020

The Windows binaries for Graphviz 2.44 are available here:

It looks like they've improved the Windows build/deployment process (so hopefully the binaries will continue to be available for future releases):

@magjac
Copy link

magjac commented Aug 28, 2020

Yes, and we are continuing to improve the build process. See e.g. https://gitlab.com/graphviz/graphviz/-/merge_requests/1529.

@h-vetinari
Copy link
Member

Was surprised that this is not building for windows anymore when I casually came across the recipe.

Might give it a shot to build it if I find some time...

@jakirkham
Copy link
Member

Now building from source(!) on Windows with PR ( #59 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants