-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the osx-arm64 build #45
Conversation
The arm64 mac has `$(uname -m)` as `arm64` not `arm`
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, the Azure runners we have access to never hit proper osx-64
hardware so there isn't a way to really test this
I can at least verify that making this change to my local $CONDA_PREFIX/bin/gmx
file (from an existing build) gets a gmx --version
working where it previously crashed looking for something with SSE in the path
I did this change to my local M1 mac and it works now. |
I tried to make the match more flexible. If someone can do a local test on Mac ARM, then I think we shoudl merge asap! |
The arm64 mac has
$(uname -m)
asarm64
notarm
Fix #44
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)