Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the osx-arm64 build #45

Merged
merged 7 commits into from
May 6, 2024
Merged

Fix the osx-arm64 build #45

merged 7 commits into from
May 6, 2024

Conversation

xiki-tempula
Copy link
Contributor

@xiki-tempula xiki-tempula commented May 3, 2024

The arm64 mac has $(uname -m) as arm64 not arm
Fix #44

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

The arm64 mac has `$(uname -m)` as `arm64` not `arm`
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Copy link
Member

@mattwthompson mattwthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, the Azure runners we have access to never hit proper osx-64 hardware so there isn't a way to really test this

I can at least verify that making this change to my local $CONDA_PREFIX/bin/gmx file (from an existing build) gets a gmx --version working where it previously crashed looking for something with SSE in the path

@xiki-tempula
Copy link
Contributor Author

I did this change to my local M1 mac and it works now.

@xiki-tempula
Copy link
Contributor Author

xiki-tempula commented May 4, 2024

@douglowe @mabraham Shall we consider merging this ASAP? As without this patch none of the arm64 build would work. We might also want to deprecate all the existing arm64 builds as they are all broken.

@mabraham
Copy link
Contributor

mabraham commented May 5, 2024

I tried to make the match more flexible. If someone can do a local test on Mac ARM, then I think we shoudl merge asap!

recipe/build.sh Outdated Show resolved Hide resolved
recipe/build.sh Outdated Show resolved Hide resolved
@mabraham mabraham merged commit 7a9b8d3 into conda-forge:main May 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build against GROMACS on macOS due to missing GMXRC
3 participants