Privatize zlib + friends; build shared on win; bump to 1.55, build with protobuf 4.23 #243

h-vetinari · 2022-09-12T15:19:55Z

Follow-up to #213 / #236, cleaned up version of #237.

Also trying to switch to shared builds on windows.

Enabling the pkg-config tests on windows needs some more work in abseil, see #242

Closes #237
Closes #246
Closes #296

conda-forge-linter · 2022-09-12T15:20:05Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari · 2022-09-12T16:08:51Z

Preserving the log as azure will delete on push due to the very slow osx agent we caught

[1174/1200] Linking CXX shared library grpc.dll
FAILED: grpc.dll grpc.lib 
cmd.exe /C "cmd.exe /C "D:\bld\grpc-split_1662996274711\_build_env\Library\bin\cmake.exe -E __create_def D:\bld\grpc-split_1662996274711\work\build-cpp\CMakeFiles\grpc.dir\.\exports.def D:\bld\grpc-split_1662996274711\work\build-cpp\CMakeFiles\grpc.dir\.\exports.def.objs && cd D:\bld\grpc-split_1662996274711\work\build-cpp" && D:\bld\grpc-split_1662996274711\_build_env\Library\bin\cmake.exe -E vs_link_dll --intdir=CMakeFiles\grpc.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\grpc.rsp  /out:grpc.dll /implib:grpc.lib /pdb:grpc.pdb /dll /version:26.0 /machine:x64 /INCREMENTAL:NO  /DEF:CMakeFiles\grpc.dir\.\exports.def  && cd ."
LINK: command "C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\grpc.rsp /out:grpc.dll /implib:grpc.lib /pdb:grpc.pdb /dll /version:26.0 /machine:x64 /INCREMENTAL:NO /DEF:CMakeFiles\grpc.dir\.\exports.def /MANIFEST /MANIFESTFILE:grpc.dll.manifest" failed (exit code 1120) with the following output:
   Creating library grpc.lib and object grpc.exp
alts_tsi_handshaker.cc.obj : error LNK2001: unresolved external symbol upb_alloc_global
transport_security_common_api.cc.obj : error LNK2001: unresolved external symbol upb_alloc_global
rls.cc.obj : error LNK2001: unresolved external symbol upb_alloc_global
xds_api.cc.obj : error LNK2001: unresolved external symbol upb_alloc_global
status_helper.cc.obj : error LNK2001: unresolved external symbol upb_alloc_global
alts_handshaker_client.cc.obj : error LNK2001: unresolved external symbol upb_alloc_global
backend_metric.cc.obj : error LNK2001: unresolved external symbol upb_alloc_global
health_check_client.cc.obj : error LNK2001: unresolved external symbol upb_alloc_global
grpclb.cc.obj : error LNK2001: unresolved external symbol upb_alloc_global
oob_backend_metric.cc.obj : error LNK2001: unresolved external symbol upb_alloc_global
alts_tsi_handshaker.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
completion_queue.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
init.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
lame_client.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
server.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
call.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
call_details.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
channel.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
channel_ping.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
slice_api.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
slice_buffer_api.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
byte_buffer.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
byte_buffer_reader.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
grpc_tls_certificate_provider.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
grpc_tls_certificate_verifier.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
grpc_tls_credentials_options.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
server_auth_filter.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
iam_credentials.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
jwt_credentials.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
jwt_verifier.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
plugin_credentials.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
api.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
security_context.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
credentials.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
google_default_credentials.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
iomgr.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
resolve_address_windows.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
timer_manager.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
sleep.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
channelz_registry.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
endpoint_pair_windows.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
executor.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
iocp_windows.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
chttp2_server.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
inproc_transport.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
xds_client.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
xds_server_config_fetcher.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
channel_connectivity.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
grpclb.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
subchannel.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
chttp2_connector.cc.obj : error LNK2001: unresolved external symbol "private: static struct std::atomic<bool> grpc_core::Fork::support_enabled_" (?support_enabled_@Fork@grpc_core@@0U?$atomic@_N@std@@A)
grpc.dll : fatal error LNK1120: 2 unresolved externals

ninja: build stopped: subcommand failed.

h-vetinari · 2022-09-13T22:23:27Z

@isuruf

I managed to get rid of the linkage errors for upb_alloc_global, but for 1.48, there's a private static member that's eluding me (I'm starting with 1.48 directly with no intention to backport this change to 1.46/47, because I'd like to leave those versions stable now, and rather only do it for 1.48 and then see how the migration for that goes).

I tried a bunch of combinations of dllimport (based on the definition of ABSL_DLL, I would have expected we need dllexport while building, but this fails even harder), and marking either the member declaration (in .h), its definition (in .cc) or the whole class as dllimport, or even the member as public. But I struggle to find the right combination for this - my C++-foo is not the best, and certainly not when combined with the MSVC shenanigans.

If you have some insights on that, this would be much appreciated. 🙃

h-vetinari · 2022-09-16T15:25:24Z

@isuruf
It's surprisingly tricky to google useful information on the the dllimport / export stuff (especially in conjunction with class members), so if the solution is obvious to you, I'd appreciate if you could share some pointers. :)

h-vetinari · 2022-09-23T19:12:33Z

Thanks for the help!

Would you have anything against making the name a bit more homogeneous, i.e.
grpc_EXPORTS, GRPC_CONSUME_DLL -> gRPC_DLL_EXPORTS, gRPC_DLL_IMPORTS
resp.:

// Note: gRPC_DLL_EXPORTS is set by CMake when building the DLL
//       gRPC_DLL_IMPORTS is part of the interface for consumers of the DLL
#if defined(gRPC_DLL_EXPORTS)
#define GRPC_DLL __declspec(dllexport)
#elif defined(gRPC_DLL_IMPORTS)
#define GRPC_DLL __declspec(dllimport)
#else
#define GRPC_DLL
#endif // defined(gRPC_DLL_EXPORTS)

Also: fair warning that I'm going to rebase out my garbage commits.

h-vetinari · 2022-09-23T19:16:15Z

On closer inspection, since I don't find grpc_EXPORTS specified anywhere I guess you're relying on CMake here - seems <target>_EXPORTS gets populated automatically...

h-vetinari · 2022-09-23T19:20:59Z

I think it might be cleaner to override this default from DEFINE_SYMBOL

h-vetinari · 2022-09-23T19:21:55Z

Or maybe not override it. In any case, <target_name>_IMPORTS seems to be unoccupied, so I'm also fine with closing the symmetry gap like that.

h-vetinari · 2022-09-23T19:23:27Z

LINK : fatal error LNK1181: cannot open input file 'address_sorting.lib'

I think we're going to need set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON) globally after all.

I had it in the bat script before.

h-vetinari · 2022-09-23T20:13:58Z

This is so weird to me...

error LNK2001: unresolved external symbol upb_alloc_global

is back now that we're using the by-the-book setup, but it was not an issue when it had just been hardcoded to __declspec(dllimport). And that private static member is still missing...

PS. Link to CI run that just finished

h-vetinari · 2022-09-23T20:52:56Z

Ah, just noticed that we're in a different lib here still...

[1167/1200] Linking CXX shared library grpc_unsecure.dll
FAILED: grpc_unsecure.dll grpc_unsecure.lib

And grpc_unsecure does not depend on grpc itself (nor the other way around), so I think we'll have to go back to explicitly setting a common variable (like ABSL_BUILD_DLL resp what I had before).

recipe/patches/0009-add-GRPC_DLL-mechanism-for-missing-symbols-on-window.patch

h-vetinari · 2022-09-23T21:16:05Z

I'm going to try what I had in mind here, but to be clear: I'm very grateful for your help and in no way do I want to be disrespectful by force-pushing over your changes. That's why I opened #246, so we can both iterate without sharing the same PR.

h-vetinari · 2022-09-23T22:14:47Z

Well, the whole dance around grpc_core::Fork::support_enabled_ is a bit pointless on windows (no fork), which is also explicitly pointed out (though the only mention I found of this was in the python bindings)

h-vetinari · 2022-10-14T21:54:57Z

@isuruf
Do you think we should still pursue this? I don't want to keep stalling versions indefinitely; now there's 1.50 out and I've been waiting for a resolution to the privatization thing before starting a new migration, but it seems that we should just move on with the current state (needing zlib at runtime) & retry again after 1.50?

At least I'm not confident I can shepherd this to completion, the windows symbol export stuff is just excruciating (I've also been really low on FOSS-time recently), and I'm out of ideas after we've now effectively copied the whole

#if defined(gRPC_DLL_EXPORTS)
#define GRPC_DLL __declspec(dllexport)
#elif defined(gRPC_DLL_IMPORTS)
#define GRPC_DLL __declspec(dllimport)
#else
#define GRPC_DLL
#endif // defined(gRPC_DLL_EXPORTS)

shebang, and it still not working.

h-vetinari · 2022-10-21T05:59:48Z

Ping @isuruf, any further thoughts here?

Otherwise I think it's time to merge the PR for 1.49 and then start migrating 1.49 (skipping 1.48). We could use 1.50 to iterate on the privatization part.

recipe/patches/0009-add-GRPC_DLL-mechanism-for-missing-symbols-on-window.patch

isuruf · 2022-10-22T05:15:01Z

You need to do

set_target_properties(upb PROPERTIES DEFINE_SYMBOL "gRPC_DLL_EXPORTS")

around https://github.com/grpc/grpc/blob/v1.48.1/CMakeLists.txt#L4215

h-vetinari · 2022-10-22T05:35:45Z

OK I'll try, thanks a lot! What do you think we should do about grpc_core::Fork::support_enabled_?

Unconditionally set it to False on windows?

h-vetinari · 2022-10-22T06:07:49Z

upb_alloc_global still missing even with the DEFINE_SYMBOL in place; grpc_core::Fork::support_enabled_ unchanged of course.

recipe/patches/0009-add-GRPC_DLL-mechanism-for-missing-symbols-on-window.patch

h-vetinari · 2022-10-22T07:08:36Z

I had a commit with the rename lined up (even though the interaction is not clear to me), but was waiting for CI to finish (I don't like how azure deletes logs of interrupted runs; makes going back to previous logs much harder).

In any case, I pushed your changes to #246. Like I asked above, please use that one if you want to iterate.

h-vetinari · 2022-10-22T10:10:49Z

Not sure if this rabbit hole ever ends... Despite doing the same for some more missing symbols now (even disambiguating further), I still run into:

server_cc.cc.obj : error LNK2001: unresolved external symbol "private: static class grpc_core::ExecCtx * grpc_core::ExecCtx::exec_ctx_" (?exec_ctx_@ExecCtx@grpc_core@@0PEAV12@EA)
client_callback.cc.obj : error LNK2001: unresolved external symbol "private: static class grpc_core::ExecCtx * grpc_core::ExecCtx::exec_ctx_" (?exec_ctx_@ExecCtx@grpc_core@@0PEAV12@EA)
alarm.cc.obj : error LNK2001: unresolved external symbol "private: static class grpc_core::ExecCtx * grpc_core::ExecCtx::exec_ctx_" (?exec_ctx_@ExecCtx@grpc_core@@0PEAV12@EA)
channel_arguments.cc.obj : error LNK2001: unresolved external symbol "private: static class grpc_core::ExecCtx * grpc_core::ExecCtx::exec_ctx_" (?exec_ctx_@ExecCtx@grpc_core@@0PEAV12@EA)
server_callback.cc.obj : error LNK2001: unresolved external symbol "private: static class grpc_core::ExecCtx * grpc_core::ExecCtx::exec_ctx_" (?exec_ctx_@ExecCtx@grpc_core@@0PEAV12@EA)
alarm.cc.obj : error LNK2019: unresolved external symbol "private: static class grpc_core::ApplicationCallbackExecCtx * grpc_core::ApplicationCallbackExecCtx::callback_exec_ctx_" (?callback_exec_ctx_@ApplicationCallbackExecCtx@grpc_core@@0PEAV12@EA) referenced in function "public: __cdecl grpc_core::ApplicationCallbackExecCtx::ApplicationCallbackExecCtx(void)" (??0ApplicationCallbackExecCtx@grpc_core@@QEAA@XZ)
default_health_check_service.cc.obj : error LNK2019: unresolved external symbol grpc_health_v1_HealthCheckRequest_msginit referenced in function "private: static bool __cdecl grpc::DefaultHealthCheckService::HealthCheckServiceImpl::DecodeRequest(class grpc::ByteBuffer const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *)" (?DecodeRequest@HealthCheckServiceImpl@DefaultHealthCheckService@grpc@@CA_NAEBVByteBuffer@3@PEAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
default_health_check_service.cc.obj : error LNK2019: unresolved external symbol grpc_health_v1_HealthCheckResponse_msginit referenced in function "private: static bool __cdecl grpc::DefaultHealthCheckService::HealthCheckServiceImpl::EncodeResponse(enum grpc::DefaultHealthCheckService::ServingStatus,class grpc::ByteBuffer *)" (?EncodeResponse@HealthCheckServiceImpl@DefaultHealthCheckService@grpc@@CA_NW4ServingStatus@23@PEAVByteBuffer@3@@Z)
call_metric_recorder.cc.obj : error LNK2019: unresolved external symbol xds_data_orca_v3_OrcaLoadReport_msginit referenced in function "private: class std::optional<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > __cdecl grpc::experimental::CallMetricRecorder::CreateSerializedReport(void)" (?CreateSerializedReport@CallMetricRecorder@experimental@grpc@@AEAA?AV?$optional@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@std@@XZ)

grpc++_unsecure.dll : fatal error LNK1120: 5 unresolved externals

Co-Authored-By: Isuru Fernando <isuruf@gmail.com>

…nda-forge-pinning 2023.05.17.15.05.36

This reverts commit 82da7b4.

h-vetinari force-pushed the private branch 2 times, most recently from 9cf0256 to 2fe8f8f Compare September 23, 2022 20:16

h-vetinari commented Sep 23, 2022

View reviewed changes

recipe/patches/0009-add-GRPC_DLL-mechanism-for-missing-symbols-on-window.patch Outdated Show resolved Hide resolved

h-vetinari mentioned this pull request Sep 23, 2022

Privatize zlib + friends; build shared on windows [alt.] #246

Closed

h-vetinari force-pushed the private branch 2 times, most recently from f5068cb to ebced64 Compare September 23, 2022 22:08

isuruf reviewed Oct 21, 2022

View reviewed changes

recipe/patches/0009-add-GRPC_DLL-mechanism-for-missing-symbols-on-window.patch Outdated Show resolved Hide resolved

isuruf reviewed Oct 22, 2022

View reviewed changes

recipe/patches/0009-add-GRPC_DLL-mechanism-for-missing-symbols-on-window.patch Outdated Show resolved Hide resolved

isuruf force-pushed the private branch from c33f7e1 to f5be2b9 Compare October 22, 2022 07:01

h-vetinari force-pushed the private branch from f5be2b9 to bcbe895 Compare October 22, 2022 07:08

h-vetinari and others added 11 commits May 18, 2023 18:51

reinstate patch to mark c-ares/re2/zlib as private

649e570

re-add zlib for grpcio

bc4d29f

add {GPR,GRPC,GRPCXX,UBP}_DLL mechanism for missing symbols on windows

ebe12a3

Co-Authored-By: Isuru Fernando <isuruf@gmail.com>

be explicit about not using static MSVC runtime

418e311

ensure zlib is found by pkg-config on windows

a9ec544

fix thread_local vs. windows

433a542

build for 1.55.0 pre-release

02d31e2

rebase patches

c0fc0d8

use newest protbuf that's required by grpc 1.55

9563717

remove obsolete compiler pins

0d83d63

MNT: Re-rendered with conda-build 3.24.0, conda-smithy 3.23.1, and co…

89ceda2

…nda-forge-pinning 2023.05.17.15.05.36

h-vetinari force-pushed the private branch from e266f46 to 89ceda2 Compare May 18, 2023 07:51

h-vetinari added 2 commits May 18, 2023 19:25

Revert "disable cmake compilation tests on unix for now"

72fffc7

This reverts commit 82da7b4.

specify path to protoc on windows

502148f

h-vetinari force-pushed the private branch from f526a51 to 502148f Compare May 18, 2023 09:30

This was referenced May 18, 2023

[Build] WIP: Shared builds on windows grpc/grpc#33175

Merged

grpc-cpp v1.55.0 #296

Closed

1.55.0 GA

6ce9d15

h-vetinari changed the title ~~Privatize zlib + friends; build shared on windows~~ Privatize zlib + friends; build shared on win; bump to 1.55, build with protobuf 4.23 May 24, 2023

update abi_migration_branches

0a8c556

h-vetinari merged commit 04dcf68 into conda-forge:main May 24, 2023
1 of 8 checks passed

h-vetinari deleted the private branch May 24, 2023 01:51

This was referenced May 24, 2023

migrate libprotobuf 4.23 & grpc 1.55 (additionally to existing pins) conda-forge/conda-forge-pinning-feedstock#4482

Merged

Next round of abseil / grpc / protobuf upgrades conda-forge/conda-forge-pinning-feedstock#4075

Open

DerThorsten mentioned this pull request Jun 1, 2023

[bot-automerge] grpcio-tools v1.55.0 conda-forge/grpcio-tools-feedstock#28

Closed

3 tasks

h-vetinari mentioned this pull request Jun 16, 2023

Problems with generated protos and DLLs on Windows googleapis/google-cloud-cpp#5849

Closed

h-vetinari mentioned this pull request Aug 14, 2023

[Python][FlightRPC] Tests segfault on OSX in conda-forge apache/arrow#36908

Closed

h-vetinari mentioned this pull request Feb 6, 2024

grpc-cpp v1.61.0 #348

Merged

3 tasks

This was referenced May 30, 2024

SciPy 1.14.0rc1 conda-forge/scipy-feedstock#277

Open

BUG: first shared library in scipy fails to be consumed by MSVC scipy/scipy#20840

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Privatize zlib + friends; build shared on win; bump to 1.55, build with protobuf 4.23 #243

Privatize zlib + friends; build shared on win; bump to 1.55, build with protobuf 4.23 #243

h-vetinari commented Sep 12, 2022 •

edited

conda-forge-linter commented Sep 12, 2022

h-vetinari commented Sep 12, 2022 •

edited

h-vetinari commented Sep 13, 2022

h-vetinari commented Sep 16, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Oct 14, 2022

h-vetinari commented Oct 21, 2022

isuruf commented Oct 22, 2022

h-vetinari commented Oct 22, 2022

h-vetinari commented Oct 22, 2022

h-vetinari commented Oct 22, 2022

h-vetinari commented Oct 22, 2022

Privatize zlib + friends; build shared on win; bump to 1.55, build with protobuf 4.23 #243

Privatize zlib + friends; build shared on win; bump to 1.55, build with protobuf 4.23 #243

Conversation

h-vetinari commented Sep 12, 2022 • edited

conda-forge-linter commented Sep 12, 2022

h-vetinari commented Sep 12, 2022 • edited

h-vetinari commented Sep 13, 2022

h-vetinari commented Sep 16, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Sep 23, 2022

h-vetinari commented Oct 14, 2022

h-vetinari commented Oct 21, 2022

isuruf commented Oct 22, 2022

h-vetinari commented Oct 22, 2022

h-vetinari commented Oct 22, 2022

h-vetinari commented Oct 22, 2022

h-vetinari commented Oct 22, 2022

h-vetinari commented Sep 12, 2022 •

edited

h-vetinari commented Sep 12, 2022 •

edited