Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jpeg module #66

Merged
merged 4 commits into from
Mar 15, 2022
Merged

add jpeg module #66

merged 4 commits into from
Mar 15, 2022

Conversation

kuepe-sl
Copy link
Contributor

@kuepe-sl kuepe-sl commented Mar 2, 2022

This PR adds the jpeg dependency, thus enabling the build of the gstjpeg module that allows for JPEG de-/encoding.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@kuepe-sl
Copy link
Contributor Author

kuepe-sl commented Mar 2, 2022

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits March 2, 2022 10:19
@kuepe-sl
Copy link
Contributor Author

kuepe-sl commented Mar 3, 2022

The Windows build should succeed after conda-forge/jpeg-feedstock#31 is merged.

@kuepe-sl
Copy link
Contributor Author

kuepe-sl commented Mar 9, 2022

It looks like the libjpeg Windows patch may need some additional work and/or discussion.
Thus I implemented a fallback mechanism into the GStreamer JPEG import module that is able to find libjpeg without the need for a CMake or pkg-config module.

From my side this ready now.

@andfoy
Copy link
Contributor

andfoy commented Mar 15, 2022

@kuepe-sl, thanks for this contribution. It looks good to me

@andfoy andfoy merged commit 377e39a into conda-forge:main Mar 15, 2022
@kuepe-sl kuepe-sl deleted the add-jpeg branch October 17, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants