Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for hdf5 1.12.1 #28

Closed
wants to merge 4 commits into from
Closed

Conversation

Anthchirp
Copy link
Member

@Anthchirp Anthchirp commented Sep 28, 2021

Checklist

This also disables Python 3.6 builds

h5py follows NEP-29 and has dropped Python 3.6 support in Oct 2020,
h5py/h5py@0748060, associated PR with more info: h5py/h5py#1727

The conda-forge h5py package does not build on Python 3.6 any more,
conda-forge/h5py-feedstock@70b5c7d

therefore there is no Python 3.6 h5py build for HDF5 1.12.

The solution therefore is to drop Python 3.6 builds downstream, too.
If there has to be a future Python 3.6 build of hdf5plugin then that
may have to go into a feedstock branch.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Anthchirp
Copy link
Member Author

@conda-forge-admin, please rerender

conda-forge-linter and others added 2 commits September 28, 2021 15:48
h5py follows NEP-29 and has dropped Python 3.6 support in Oct 2020,
h5py/h5py@0748060

The conda-forge h5py package does not build on Python 3.6 any more,
conda-forge/h5py-feedstock@70b5c7d

therefore there is no Python 3.6 h5py build for HDF5 1.12.

The solution therefore is to drop Python 3.6 builds downstream, too.
If there has to be a Python 3.6 build of hdf5plugin then that may have
to go into a branch, based off a commit preceeding this commit.
@Anthchirp
Copy link
Member Author

@conda-forge-admin, please rerender

@Anthchirp
Copy link
Member Author

Not sure why the linux_ppc64le_python3.9.____cpython build fails with

Failed to load filter blosc: /home/conda/feedstock_root/build_artifacts/hdf5plugin_1632846866921/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.9/site-packages/hdf5plugin/plugins/libh5blosc.so
.E......
======================================================================
ERROR: testBlosc (hdf5plugin.test.TestHDF5PluginRW)
Write/read test with blosc filter plugin
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/hdf5plugin_1632846866921/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.9/site-packages/hdf5plugin/test.py", line 116, in testBlosc
    self._test('blosc')  # Default options
  File "/home/conda/feedstock_root/build_artifacts/hdf5plugin_1632846866921/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.9/site-packages/hdf5plugin/test.py", line 72, in _test
    f.create_dataset("data", data=data, chunks=data.shape, **args)
  File "/home/conda/feedstock_root/build_artifacts/hdf5plugin_1632846866921/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.9/site-packages/h5py/_hl/group.py", line 149, in create_dataset
    dsid = dataset.make_new_dset(group, shape, dtype, data, name, **kwds)
  File "/home/conda/feedstock_root/build_artifacts/hdf5plugin_1632846866921/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.9/site-packages/h5py/_hl/dataset.py", line 107, in make_new_dset
    dcpl = filters.fill_dcpl(
  File "/home/conda/feedstock_root/build_artifacts/hdf5plugin_1632846866921/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.9/site-packages/h5py/_hl/filters.py", line 281, in fill_dcpl
    raise ValueError("Unknown compression filter number: %s" % compression)
ValueError: Unknown compression filter number: 32001

@t20100
Copy link
Contributor

t20100 commented Oct 1, 2021

Looks weird: Other filters work fine, other versions of python also..

@t20100
Copy link
Contributor

t20100 commented Oct 13, 2021

There is an issue with a missing symbol from pthread occuring in this case, so I added link to pthread explicitly.
I fixed it (see silx-kit/hdf5plugin#154), and will prepare a new release.

@Anthchirp
Copy link
Member Author

Thank you for looking into this 👍

@Anthchirp
Copy link
Member Author

Resolved in #31

@Anthchirp Anthchirp closed this Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants