Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 0.8.0 and include support for Windows. #15

Merged
merged 29 commits into from Apr 3, 2020

Conversation

vtraag
Copy link
Contributor

@vtraag vtraag commented Feb 10, 2020

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This PR updates igraph to version 0.8.0. Unlike PR #14, this also includes support for Windows. The support for Windows is submitted separately in this PR, so that if any issues present themselves, it doesn't conflict with the update to version 0.8.0 for other platforms, and PR #14 can still be merged.

There are hence two options: (1) all goes well, and we can merge this PR (in which case we should set the build number to 0); (2) problems galore, in which case PR #14 could simply be merged, and I continue working on this PR.

@vtraag vtraag requested a review from sodre as a code owner February 10, 2020 21:53
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [8, 9, 10, 27, 28, 29, 30, 33, 34, 35, 36, 37, 38, 40, 41, 42, 43, 44, 45]

@vtraag
Copy link
Contributor Author

vtraag commented Feb 10, 2020

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [28, 51, 56]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@vtraag
Copy link
Contributor Author

vtraag commented Feb 11, 2020

It took some time, but I think option (1) should now be followed, and this PR should be favoured over PR #14. I have reset build number to 0, and this could be merged.

@vtraag vtraag mentioned this pull request Feb 11, 2020
4 tasks
@vtraag vtraag mentioned this pull request Feb 11, 2020
33 tasks
@vtraag
Copy link
Contributor Author

vtraag commented Feb 14, 2020

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance. You can also try re-rendering locally.

@vtraag vtraag mentioned this pull request Feb 16, 2020
@vtraag
Copy link
Contributor Author

vtraag commented Mar 29, 2020

Ping @sodre could you please take a look at this PR?

I'd be happy to be added as a maintainer of this feedstock. I am currently commited to the development of the igraph project itself. Maintaining the conda feedstock would then only make sense from that perspective, and I am already a maintainer of python-igraph feedstock.

@vtraag
Copy link
Contributor Author

vtraag commented Mar 29, 2020

Note that this PR also fixes the issue addressed in PR #7, which can then also be closed.

@sodre
Copy link
Member

sodre commented Apr 3, 2020

@conda-forge-admin, please rerender

1 similar comment
@sodre
Copy link
Member

sodre commented Apr 3, 2020

@conda-forge-admin, please rerender

Copy link
Member

@sodre sodre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am just waiting for the windows build to pass again before merging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@sodre sodre merged commit b1d16a4 into conda-forge:master Apr 3, 2020
@sodre sodre mentioned this pull request Apr 9, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants