Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.1.2 #12

Merged
merged 4 commits into from
Jan 15, 2021
Merged

Update to 1.1.2 #12

merged 4 commits into from
Jan 15, 2021

Conversation

adrianchia
Copy link
Contributor

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [10].

@dpryan79
Copy link

@conda-forge/keras-preprocessing Can this get merged? It's blocking stuff on Bioconda.

@h-vetinari
Copy link
Member

Also interested in this for trying to get conda-forge/tensorflow-feedstock#110 working

@dpryan79
Copy link

@conda-forge/core The maintainer isn't responsive at the moment, could one of you merge this?

@xhochy
Copy link
Member

xhochy commented Jan 15, 2021

@conda-forge-admin please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [10].
  • noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.

@xhochy
Copy link
Member

xhochy commented Jan 15, 2021

Would be nice if someone could fix the lint issues and step up as a maintainer

@h-vetinari
Copy link
Member

Would be nice if someone could fix the lint issues and step up as a maintainer

I'd be up for it: #14

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari merged commit ab4a57f into conda-forge:master Jan 15, 2021
@h-vetinari
Copy link
Member

Thanks @adrianchia @dpryan79 @xhochy

@h-vetinari
Copy link
Member

Also leaving this as a reference why the bot didn't pick this up: keras-team/keras-preprocessing#305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants