Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3.4.2, re-work patches (git format), add tests #51

Open
wants to merge 54 commits into
base: main
Choose a base branch
from

Conversation

mingwandroid
Copy link
Contributor

@mingwandroid mingwandroid commented Apr 16, 2020

Checklist

  • Used a fork of the feedstock to propose changes
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mingwandroid
Copy link
Contributor Author

mingwandroid commented Apr 16, 2020

Do not merge this until the PRs to the other compression libraries have been merged (at which point we need to rebuild this).

@wolfv
Copy link
Member

wolfv commented May 12, 2020

Hey, are we still waiting for other compression libraries?

I'm happy to help here

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like I wasn't able to push to the master branch of AnacondaRecipes/libarchive-feedstock. Did you check the "Allow edits from maintainers" box?

NOTE: PRs from organization accounts cannot be rerendered because of GitHub permissions.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libarchive-feedstock/actions/runs/2343809981.

@jakirkham
Copy link
Member

Yeah GitHub doesn't allow branch editing of org fork PRs. As a result the bot can't push the re-render. So someone will need to do re-rendering on the Anaconda side or this needs to be resubmitted as a new PR

cc @katietz (as it looks like you were working on this last 🙂)

@jakirkham
Copy link
Member

Think we can drop all of the Visual Studio 2008 bits as those are not used any more in conda-forge. Might simplify the update process

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like I wasn't able to push to the master branch of AnacondaRecipes/libarchive-feedstock. Did you check the "Allow edits from maintainers" box?

NOTE: PRs from organization accounts or PRs from forks made from organization forks cannot be rerendered because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libarchive-feedstock/actions/runs/4004317275.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants