-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test for symlink and move tests to top level. #10
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/libcublas-feedstock/actions/runs/4647093322. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdice was there anything else you wanted to add here? Looks like it is marked as draft so wanted to be sure before I merge
@adibbley Yes, I mentioned this to @jakirkham and these tests aren’t running. We probably have to put the tests for libcublas in the top level instead of the subpackage output because of the name conflict. Haven’t made that change yet but will do so soon. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
test: | ||
commands: | ||
- test -L $PREFIX/lib/libcublas.so.{{ version }} # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So just to confirm, moving these test
s to the top-level worked?
If so, would move these to after outputs
, but before about
in the top-level portion of the recipe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, moving this to the top level worked. I verified in the CI output.
The conda-forge linter won't let us put this key in any other place:
For recipe:
- The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'test', 'outputs', 'about', 'extra'].
@adibbley This should be ready to merge when you're able. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)While reviewing conda-forge/staged-recipes#21902, I noticed that the tests for libcublas on Linux were checking if
libcublas.so.12
is a file andlibcublas.so.12.0.1.189
is a symlink. However, that's backwards.libcublas.so.12
should be a symlink pointing tolibcublas.so.12.0.1.189
. I'm not sure how this passed CI before, becausetest -L $PREFIX/targets/{{ target_name }}/lib/libcublas.so.{{ version }}
should not pass from what I can tell.