Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for symlink and move tests to top level. #10

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 8, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

While reviewing conda-forge/staged-recipes#21902, I noticed that the tests for libcublas on Linux were checking if libcublas.so.12 is a file and libcublas.so.12.0.1.189 is a symlink. However, that's backwards. libcublas.so.12 should be a symlink pointing to libcublas.so.12.0.1.189. I'm not sure how this passed CI before, because test -L $PREFIX/targets/{{ target_name }}/lib/libcublas.so.{{ version }} should not pass from what I can tell.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bdice
Copy link
Contributor Author

bdice commented Apr 8, 2023

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libcublas-feedstock/actions/runs/4647093322.

Copy link
Contributor

@adibbley adibbley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdice was there anything else you wanted to add here? Looks like it is marked as draft so wanted to be sure before I merge

@bdice
Copy link
Contributor Author

bdice commented Apr 11, 2023

@adibbley Yes, I mentioned this to @jakirkham and these tests aren’t running. We probably have to put the tests for libcublas in the top level instead of the subpackage output because of the name conflict. Haven’t made that change yet but will do so soon.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'test', 'outputs', 'about', 'extra'].

recipe/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Comment on lines +30 to +32
test:
commands:
- test -L $PREFIX/lib/libcublas.so.{{ version }} # [linux]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just to confirm, moving these tests to the top-level worked?

If so, would move these to after outputs, but before about in the top-level portion of the recipe

Copy link
Contributor Author

@bdice bdice Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, moving this to the top level worked. I verified in the CI output.

The conda-forge linter won't let us put this key in any other place:

For recipe:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'test', 'outputs', 'about', 'extra'].

@bdice
Copy link
Contributor Author

bdice commented Apr 12, 2023

@adibbley This should be ready to merge when you're able.

@adibbley adibbley merged commit a89c4b6 into conda-forge:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants