Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libdeflate-gzip binary. Add extra maintainer volunteer. #4

Closed

Conversation

rhpvorderman
Copy link
Contributor

@rhpvorderman rhpvorderman commented Aug 13, 2020

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Libdeflate does not override the gzip application. See ebiggers/libdeflate#71 .
Therefore we can install it in the conda package. This will make it easier for people to use libdeflate as a drop-in replacement for zlib as they can use the libdeflate-gzip application which is much faster.

I also volunteered as a maintainer for this package and added the LICENSE file as it did not seem to be included. (But this might be me not understanding the packaging correctly).

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@rhpvorderman
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@rhpvorderman rhpvorderman changed the title Add libdeflate-gzip package. Add extra maintainer volunteer. Add libdeflate-gzip binary. Add extra maintainer volunteer. Aug 13, 2020
@hmaarrfk
Copy link
Contributor

Is there any desire in getting this in? It seems like a useful addition.

@hmaarrfk
Copy link
Contributor

I merged this into: #8

Thanks

@hmaarrfk hmaarrfk closed this Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants