Support for osx-arm64 builds #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nda-forge-pinning 2022.03.04.19.31.39
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
stepanhruda
commented
Mar 7, 2022
| @@ -17,6 +17,7 @@ build: | |||
| requirements: | |||
| build: | |||
| - cmake >=3.12 | |||
| - make | |||
There was a problem hiding this comment.
This is literally the only manual change, everything else is the work of conda-forge's automatic migrator
There was a problem hiding this comment.
@stepanhruda pls ping @tstenner and @conda-forge/core to merge
|
Do you want to be a maintainer? If so, add yourself and rerender |
|
if not ping us again ti merge |
|
I'm flattered but I'm just drive-by fixing a package. @hmaarrfk @conda-forge/core can you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Taking over automatic bot PR #3 and adding changes to hopefully get builds working. Looks like the new changes only failed on linux and osx-arm64 builds just fine, so it's probably a result of not re-rendering the config for a very long time rather than related to the new arch.