Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix for Unidata/netcdf-c#2674 #175

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Apr 18, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This hopefully fixes the issue of overly abundant HDF5-DIAG messages that has plagued a number of downstream projects.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@zklaus
Copy link
Contributor Author

zklaus commented Apr 18, 2023

@conda-forge-admin, please rerender

@zklaus
Copy link
Contributor Author

zklaus commented Apr 18, 2023

The build problem on Osx is due to a mistaken detection of clock_gettime, which is in fact not available on Osx. This is correctly detected on other Osx builds and on earlier Osx-Mpich builds. My suspicion is that the use of Cmake's CHECK_FUNCTION_EXISTS picks up a possibly wrongly exported clock_gettime from an updated dependency in the Mpich branch of the dependency tree. From the Cmake docu:

check_function_exists() only verifies linking, it does not verify that the function is declared in system headers.

As such the error is unrelated to this PR, but I'll try to address it.

Copy link
Contributor

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zklaus Thanks for doing this! It would be great to get this in soon.

Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zklaus, thanks for doing this. It will be great to have you as a maintainer.

@xylar
Copy link
Contributor

xylar commented Apr 18, 2023

I'll merge in the next few hours unless anyone objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants