Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] fix pkgconfig metadata on windows and tighten tests #209

Merged
merged 3 commits into from
Feb 20, 2024
Merged

[main] fix pkgconfig metadata on windows and tighten tests #209

merged 3 commits into from
Feb 20, 2024

Conversation

h-vetinari
Copy link
Member

pkgconfig data on windows is wrong, is looking for absl_abseil_dll, which obviously doesn't exist. Tighten the tests, then fix it.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jjerphan
jjerphan approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo 🟢 CI checks.

@h-vetinari
Copy link
Member Author

Tighten the tests, then fix it.

This is going to fail. I haven't researched a fix yet, in the process of writing an upstream issue...

@h-vetinari h-vetinari changed the title tighten pkgconfig tests [main] tighten pkgconfig tests Feb 20, 2024
@h-vetinari h-vetinari changed the title [main] tighten pkgconfig tests [main] fix pkgconfig metadata on windows and tighten tests Feb 20, 2024
@h-vetinari h-vetinari mentioned this pull request Feb 20, 2024
Merged
@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Feb 20, 2024
@h-vetinari h-vetinari mentioned this pull request Feb 20, 2024
Closed
@github-actions github-actions bot merged commit 7b8e5b3 into conda-forge:main Feb 20, 2024
8 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari h-vetinari deleted the pkgconfig branch February 20, 2024 22:51
copybara-service bot pushed a commit to protocolbuffers/protobuf that referenced this pull request Feb 22, 2024
@h-vetinari
fix pkg-config metadata for shared abseil on windows (#15888)
fe6edca 
Closes #15883, tested in conda-forge/libprotobuf-feedstock#209

Closes #15888

COPYBARA_INTEGRATE_REVIEW=#15888 from h-vetinari:absl_pkgconfig 9062aa9
PiperOrigin-RevId: 609206067
@h-vetinari h-vetinari mentioned this pull request Feb 22, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjerphan jjerphan jjerphan approved these changes

@JohanMabille JohanMabille Awaiting requested review from JohanMabille JohanMabille is a code owner

@dopplershift dopplershift Awaiting requested review from dopplershift dopplershift is a code owner

@hajapy hajapy Awaiting requested review from hajapy hajapy is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@wesm wesm Awaiting requested review from wesm wesm is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

@xylar xylar Awaiting requested review from xylar xylar is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@h-vetinari @jjerphan