-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fix for llvm/llvm-project#61402 #209
Conversation
This addresses an issue that is triggered by Numba 0.57 - see numba/numba#8738
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Doesn't numba + LLVM 14 also need the SVML patches? I have an open PR for that that didn't get any comments: #192 Let's see if this compiles a bit faster after a rerender: |
…nda-forge-pinning 2023.04.25.18.40.51
Can we please review / merge this? It will be breaking many AArch64 users of Numba. For example, UMAP is unusable on AArch64: numba/numba#8994 / lmcinnes/umap#1004 (comment). This patch has already been accepted upstream by LLVM but will not be in a release until 17.x: |
Does this change make sense without SVML? I thought that was a requirement for using llvm 14 with numba, as things would break without SVML as well. #192 is waiting for action from the numba/llvmlite team. |
This is unrelated to SVML. I don't know much about SVML but it's not required for Aarch64. So #192 should be considered completely independently of this. |
Think Graham's point here is simply this particular change has already gone upstream (and was merged). So may be more easily integrated than the other patch (orthogonal to this one), which hasn't quite made it upstream yet. |
Yeah, I got that. I just wanted to confirm what's necessary for numba or not. I haven't had time to double-check with the upstream PR (can do sometime in the next ~12h), but if you want to go ahead and merge, I don't mind! |
Happy to wait 12hrs 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was on a phone yesterday which made this hard to check again. Thanks for the fix!
No worries. Been there done that 😅 Thanks Axel! 🙏 |
Many thanks for bumping the build number and the merge! |
This addresses an issue that is triggered by Numba 0.57 - see numba/numba#8738
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)