Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.43.0rc1 #86

Merged
merged 20 commits into from
May 16, 2024
Merged

v0.43.0rc1 #86

merged 20 commits into from
May 16, 2024

Conversation

gmarkall
Copy link

@gmarkall gmarkall commented May 15, 2024

This also includes a merge of main into the rc branch. The only substantial change is 1cd97d6, which just changes the version number, tarball location, sha256sum, and build number.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

We need to use the Github tarball because it is not yet available on
PyPI.
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This reverts commit 68ab5ea.

This did not go well, with all docker builds ending with errors like:

```
conda_libmamba_solver.conda_build_exceptions.ExplainedDependencyNeedsBuildingError:
Unsatisfiable dependencies for platform linux-64:
{MatchSpec("c_linux-64")}
```
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@gmarkall
Copy link
Author

Adding stdlib("c") did not seem to work, so although I tried it, I've reverted it for now - I'd prefer to handle it separately from building the RC version.

@jakirkham jakirkham changed the base branch from main to rc May 16, 2024 03:08
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/llvmlite-feedstock/actions/runs/9105868511.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@jakirkham
Copy link
Member

jakirkham commented May 16, 2024

Adding stdlib("c") did not seem to work, so although I tried it, I've reverted it for now - I'd prefer to handle it separately from building the RC version.

Ah ok. This is mostly cosmetic now. It pulls in these dependencies already. We are just trying to be explicit, which will help when we change the GLIBC version conda-forge builds with

As to why it failed, think all we were missing was a re-render, which I've just now tried and expect to work

That said, if we run into other issues, happy to punt on this

Edit: Looks like it passed

@jakirkham
Copy link
Member

Do we want to try LLVM 15 given this release has support for it? Or do you want to wait on that?

@gmarkall
Copy link
Author

Thanks for the review!

Do we want to try LLVM 15 given this release has support for it? Or do you want to wait on that?

I don't want to try it because it's only experimental. It'd be better just just get the RC out.

@jakirkham jakirkham merged commit f1b6863 into conda-forge:rc May 16, 2024
31 checks passed
@jakirkham
Copy link
Member

Sounds good. Merged

Thanks Graham! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants