Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS code not generated #3

Closed
kylebarron opened this issue Nov 9, 2023 · 2 comments
Closed

JS code not generated #3

kylebarron opened this issue Nov 9, 2023 · 2 comments

Comments

@kylebarron
Copy link
Member

kylebarron commented Nov 9, 2023 •
edited
Loading

The JS part of lonboard is not generated, which means the released package doesn't work. See developmentseed/lonboard#225 (comment)

See how the release is done for pip here:
https://github.com/developmentseed/lonboard/blob/040b7cf8b191a41113a707acbd34f929bfbc1cc7/.github/workflows/release.yml#L26-L32
@kylebarron kylebarron mentioned this issue Nov 9, 2023
Merged
@giswqs
Copy link
Member

giswqs commented Nov 9, 2023

Thanks for checking. I will look into it.

@giswqs giswqs linked a pull request Nov 9, 2023 that will close this issue
Add JS build #4
Closed
5 tasks
@giswqs
Copy link
Member

giswqs commented Mar 19, 2024

Fixed in #11

@giswqs giswqs closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add JS build giswqs/lonboard-feedstock
2 participants
@giswqs @kylebarron