Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn on keep_pkgs in construct.yaml #31

Merged
merged 3 commits into from
May 25, 2020
Merged

turn on keep_pkgs in construct.yaml #31

merged 3 commits into from
May 25, 2020

Conversation

Shenggan
Copy link
Contributor

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

related issue #30

@hmaarrfk
Copy link
Contributor

Does this address #21 ?

@Shenggan
Copy link
Contributor Author

I think so.

Does this address #21 ?

@hmaarrfk
Copy link
Contributor

Could you add a test or a comment (in the code) as to why this is necessary.

And if you would like this to be merged first, then let me now, we will have to bump the version somehow.

@Shenggan
Copy link
Contributor Author

I add a comment in the code. And it's fine to fix it when next version release.

@scopatz
Copy link
Member

scopatz commented May 24, 2020

@Shenggan - can your comment address the hardlinking issue please? Thanks!

@hmaarrfk
Copy link
Contributor

A few words specifically referring to the issue
#21

would be good.

@Shenggan
Copy link
Contributor Author

@scopatz @hmaarrfk Thanks for suggestion.

@scopatz
Copy link
Member

scopatz commented May 25, 2020

This passed before and the only change was to a comment, so I don't know why it failed. Merging is very likely safe.

@scopatz scopatz merged commit cd2dd2b into conda-forge:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants