Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add brew installation instructions #97

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Jan 8, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@hmaarrfk hmaarrfk merged commit e75e619 into conda-forge:master Jan 8, 2021
@jakirkham
Copy link
Member

Thanks Dominik! 😄

@domoritz
Copy link
Member Author

domoritz commented Jan 8, 2021

Once Homebrew/homebrew-cask#97538 is merged, ARM should work out of the box.

I wonder whether it would be possible to automatically update the brew formula when there is a new release or whether you want to make it part of the release process. There is a command-line tool for making updates: https://github.com/Homebrew/homebrew-cask/blob/master/CONTRIBUTING.md#updating-a-cask.

@domoritz
Copy link
Member Author

domoritz commented Jan 8, 2021

Just confirmed that brew install miniforge works out of the box on a MacBook with M1.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Jan 8, 2021

is it running everything through rosetta? or native?

@domoritz
Copy link
Member Author

domoritz commented Jan 8, 2021

It's installing native versions of packages (e.g. Python) and runs natively.

See https://github.com/Homebrew/homebrew-cask/blob/34bc35b5f61a01cd3fdf36228ca9c0408be1d91a/Casks/miniforge.rb#L4 for the conditional that makes sure to download the right installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants