Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Correct deps #26

Merged
merged 3 commits into from
Oct 9, 2022
Merged

MAINT: Correct deps #26

merged 3 commits into from
Oct 9, 2022

Conversation

larsoner
Copy link
Contributor

@larsoner larsoner commented Oct 9, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@hoechenberger this was the only error I found looking at https://mne.tools/mne-bids/dev/install.html, was this what you were thinkin, did I miss something, or does the HTML need updating?

Closes #25

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@larsoner
Copy link
Contributor Author

larsoner commented Oct 9, 2022

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/mne-bids-feedstock/actions/runs/3215157763.

@larsoner
Copy link
Contributor Author

larsoner commented Oct 9, 2022

... right, and importlib_resources. I've removed that. Feel free to merge if this is what you had in mind @hoechenberger

Copy link
Contributor

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in #24 (comment) it also complained about pymatreader and edflib-python ... but no idea why. Perhaps only because we never explicitly import them in mne-bids and they are only needed in mne-python?

Anyhow, this lgtm - thanks

@hoechenberger
Copy link
Member

@larsoner I thought we don't support MNE-Python before 1.0 (or even 1.1???) anymore either, no?

@hoechenberger
Copy link
Member

and thanks for looking into this, @larsoner!!!

@sappelhoff
Copy link
Contributor

ah, right. we only support mne >= 1.0 now

@hoechenberger
Copy link
Member

in #24 (comment) it also complained about pymatreader and edflib-python

I found these heuristics to be sometimes misleading in the past in other feedstocks as well, so I wouldn't worry to much about them!

recipe/meta.yaml Outdated Show resolved Hide resolved
@hoechenberger
Copy link
Member

I think we're good now

@hoechenberger hoechenberger added the automerge Merge the PR when CI passes label Oct 9, 2022
@larsoner
Copy link
Contributor Author

larsoner commented Oct 9, 2022

in #24 (comment) it also complained about pymatreader and edflib-python ... but no idea why. Perhaps only because we never explicitly import them in mne-bids and they are only needed in mne-python?

Yes this would make sense if you make use of mne.export because the deps are via mne in that case

Thanks for the quick responses, fix, and marking for auto-merge!

@github-actions github-actions bot merged commit 386fe68 into conda-forge:main Oct 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deps need updating
4 participants