-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Correct deps #26
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/mne-bids-feedstock/actions/runs/3215157763. |
... right, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in #24 (comment) it also complained about pymatreader and edflib-python ... but no idea why. Perhaps only because we never explicitly import them in mne-bids and they are only needed in mne-python?
Anyhow, this lgtm - thanks
@larsoner I thought we don't support MNE-Python before 1.0 (or even 1.1???) anymore either, no? |
and thanks for looking into this, @larsoner!!! |
ah, right. we only support mne >= 1.0 now |
I found these heuristics to be sometimes misleading in the past in other feedstocks as well, so I wouldn't worry to much about them! |
I think we're good now |
Yes this would make sense if you make use of Thanks for the quick responses, fix, and marking for auto-merge! |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)@hoechenberger this was the only error I found looking at https://mne.tools/mne-bids/dev/install.html, was this what you were thinkin, did I miss something, or does the HTML need updating?
Closes #25