Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recipe for version 1.4 #16

Merged
merged 3 commits into from Jun 30, 2023
Merged

Update recipe for version 1.4 #16

merged 3 commits into from Jun 30, 2023

Conversation

aradi
Copy link
Contributor

@aradi aradi commented Jun 30, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • [ ] Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Note: Unfortunately, mpifx in its current form (also earlier versions) can not built with MPICH 4.x (see dftbplus/mpifx#48). Therefore, MPICH must be pinned accordingly. 😞

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@aradi aradi marked this pull request as draft June 30, 2023 14:04
@aradi
Copy link
Contributor Author

aradi commented Jun 30, 2023

@conda-forge-admin, please restart ci

@aradi
Copy link
Contributor Author

aradi commented Jun 30, 2023

@conda-forge-admin, please rerender

@aradi aradi marked this pull request as ready for review June 30, 2023 18:31
@aradi
Copy link
Contributor Author

aradi commented Jun 30, 2023

OK, now, it seems to be OK. (I've pinned MPICH to version 3. We will remove it, once the type-mismatch had been fixed in upstream...)

Copy link
Contributor

@bhourahine bhourahine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aradi aradi merged commit a0fbe3c into conda-forge:main Jun 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants