Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update list of programs to nauty 2.8.8 #24

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

dcoudert
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This PR updates the list of programs of nauty to the list of version 2.8.8. For instance, genktreeg has been introduced in version 2.8.8 and we want to use it in sagemath/sage#36924

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/build.sh Outdated Show resolved Hide resolved
dcoudert and others added 2 commits December 21, 2023 19:43
all programs of version 2.8.8 should now be listed
@isuruf isuruf added the automerge Merge the PR when CI passes label Dec 22, 2023
@isuruf
Copy link
Member

isuruf commented Dec 22, 2023

Thanks

@dcoudert
Copy link
Contributor Author

dcoudert commented Dec 22, 2023

I realize that it might not be a good idea to add all programs of nauty in the list of programs due to the following test:

if [[ "$target_platform" != win-* ]]; then
    programs="$programs countg pickg shortg"
fi

@github-actions github-actions bot merged commit 900bb83 into conda-forge:main Dec 22, 2023
6 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@dcoudert dcoudert deleted the update_list_of_programs branch December 22, 2023 08:15
@isuruf
Copy link
Member

isuruf commented Dec 22, 2023

There were compilation errors for those programs in windows, but we've disabled windows for now anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants