-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try against conda-forge vs2015 #8
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
The issue here is that you do not have %CONDA_INSTALL_LOCN%\Library\bin on PATH, so any runtimes are not being found. I'm submitting a patch against your branch here that should work. |
set PATH with activate
Hm, looks like none of the phantom tests are working... we had already dropped them from Linux, so perhaps it makes sense to just drop the tests altogether, and fall back to import tests. |
Might want to also restart this to see if the new conda build helps with the win py35 post link at all. I'd do that, but I don't have authority on this feedstock. |
Done. 😄 |
Whoops. Well, figured i'd regenerate and add the env fix... but the test fails are concerning. |
Well, everything worked once (sort of) on ec1aafb. Looks like the new pyzmq did the trick on windows... but I'm trying again to see if the tests can be run there as well. |
Ah, and the previously noted issue conda-forge/nbpresent-feedstock#3 was still appearing, so dropping the tests there again for the time being. |
Hooray! Finally fixed windows! Nice work. |
Well, building at all is much better than not building, so we'll take it over building with all the tests running. Going to merge this... |
Still seeing issues with vs2015, most likely:
conda-forge/staged-recipes#710