Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try against conda-forge vs2015 #8

Merged
merged 13 commits into from
Jul 27, 2016

Conversation

bollwyvl
Copy link
Contributor

Still seeing issues with vs2015, most likely:

conda-forge/staged-recipes#710

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@msarahan
Copy link
Member

msarahan commented Jul 7, 2016

The issue here is that you do not have %CONDA_INSTALL_LOCN%\Library\bin on PATH, so any runtimes are not being found.

I'm submitting a patch against your branch here that should work.

@bollwyvl
Copy link
Contributor Author

Hm, looks like none of the phantom tests are working... we had already dropped them from Linux, so perhaps it makes sense to just drop the tests altogether, and fall back to import tests.

@msarahan
Copy link
Member

Might want to also restart this to see if the new conda build helps with the win py35 post link at all. I'd do that, but I don't have authority on this feedstock.

@jakirkham
Copy link
Member

Might want to also restart this...

Done. 😄

@bollwyvl
Copy link
Contributor Author

Done. 😄

Whoops. Well, figured i'd regenerate and add the env fix... but the test fails are concerning.

@bollwyvl
Copy link
Contributor Author

Well, everything worked once (sort of) on ec1aafb.

Looks like the new pyzmq did the trick on windows... but I'm trying again to see if the tests can be run there as well.

@bollwyvl
Copy link
Contributor Author

Ah, and the previously noted issue conda-forge/nbpresent-feedstock#3 was still appearing, so dropping the tests there again for the time being.

@msarahan
Copy link
Member

Hooray! Finally fixed windows! Nice work.

@bollwyvl
Copy link
Contributor Author

Well, building at all is much better than not building, so we'll take it over building with all the tests running. Going to merge this...

@bollwyvl bollwyvl merged commit 2d2267c into conda-forge:master Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants