-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work on py2 anymore.... #16
Comments
@ChrisBarker-NOAA Thanks for spotting this. I'll take care of this within the next two hours. In noarch you can suppress py2k by specifying python >= 3.6 in the build/host/run sections. It is mentioned in the cf-docs somewhere. |
Thanks y'all for your packaging efforts! I just want to confirm that |
@mgeier Thanks for the confirmation. Hope that we have now fixed everything. |
I just realized that I've been releasing universal wheels up to now, but those should be Python-3-only, too, I guess. This will take care of if for future releases: spatialaudio/nbsphinx#268 |
Hmm -- not really the place for it, but the tools (both wheel building and conda packages) really should make it hard, rather than easy, to do this! (this being accidentally making a py2 package for a code that does not support py2) |
@ChrisBarker-NOAA In this case it's actually my fault. I've added a The default for I don't know about the conda process. |
The default for conda is to build both. "noarch" actually means no specific OS/processor architecture, AND no specific Python version :-( |
FYI, I'll re-enable Python 2 support in the next release, see spatialaudio/nbsphinx#274 and spatialaudio/nbsphinx#275. |
nbsphinx version 0.4.* uses the "nonlocal" keyword -- and will not run on python2
This recipe is set to
noarch: python
So it is building for py2 and py3 -- apparently it will import in py2, and thus pass the tests, but not actually run.
The source setup.py has:
I can't remember how to suppress py2 building with noarch, but it can be done :-)
The text was updated successfully, but these errors were encountered: