-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python 2 compat: avoid 'nonlocal' statement #274
Conversation
wrap open_cite_tag inside a mutable object
Thanks for this PR! Do you actually need Python 2 support? I was thinking about removing Python 2 support, see also #268. |
Lago requires |
OK I've created #275. I'm not using your PR because I don't like the "wrap it in a list" work-around for I can keep Python 2 compatibility for some more time, but at some point it will have to go away. In about a year the official support for Python 2 will end anyway ... |
I've merged #275. |
@mgeier thanks ! |
Thanks for doing this. I've manually installed updated version, but the changes introduced in this merge aren't appearing in the latest pip version and, consequently, I'm having trouble using nbsphinx on readthedocs. Would a version bump fix this? |
@jeffrey-hokanson I haven't made a new release yet, but I will make one within the next few days. In the meantime, if you are in a hurry, you can use the |
I've just uploaded the new release 0.4.2 to PyPI. |
Python 2 compatibility is broken since 0.4.0 / 46b3664.
avoid
nonlocal
statement: wrapopen_cite_tag
inside a mutable object.