Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update netgen to build on macOS for Apple Silicon #44

Closed

Conversation

oursland
Copy link

@oursland oursland commented Mar 15, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This branch bumps up the version of netgen to 6.2.2302 which includes support for building on Apple Silicon. Separate directives for the deployment target and build machine are specified to support building on and for both x86_65 and arm64 macOS.

A migration to support python3.11 is included to support the most recent build.

Closes #45

@oursland oursland requested a review from looooo as a code owner March 15, 2023 23:22
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Old-style Python selectors (py27, py34, py35, py36) are deprecated. Instead, consider using the int py. For example: # [py>=36]. See lines [18]
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@oursland oursland force-pushed the personal/joursland/apple-silicon branch 3 times, most recently from dcc11d6 to 69de452 Compare March 16, 2023 15:11
@jakirkham
Copy link
Member

Added a note in the OP to close out the macOS ARM migrator PR (since this does that work already)

@oursland oursland force-pushed the personal/joursland/apple-silicon branch from 69de452 to 63b890e Compare March 16, 2023 22:43
@mikemhenry
Copy link

I think you wanted to import netgen and not pymbar 🙃

@oursland oursland force-pushed the personal/joursland/apple-silicon branch 2 times, most recently from 3d0a0d5 to 8aa89f3 Compare March 17, 2023 01:08
@oursland oursland changed the title Personal/joursland/apple silicon Update netgen to build on macOS for Apple Silicon Mar 19, 2023
@oursland oursland force-pushed the personal/joursland/apple-silicon branch from 98d91c3 to d208a09 Compare March 24, 2023 00:58
@oursland oursland force-pushed the personal/joursland/apple-silicon branch 3 times, most recently from 5a62a7a to 50b69be Compare March 24, 2023 17:53
@looooo
Copy link
Contributor

looooo commented Mar 25, 2023

To build for osx-arm you need to add this line and render:
https://github.com/conda-forge/pivy-feedstock/blob/main/conda-forge.yml#L3

@looooo
Copy link
Contributor

looooo commented Mar 25, 2023

Just in case you don't know. For freecad Netgen is bundled with smesh:
https://github.com/trelau/SMESH/blob/master/.gitmodules#L1

@oursland oursland force-pushed the personal/joursland/apple-silicon branch from 50b69be to f8471e1 Compare March 25, 2023 21:33
@oursland
Copy link
Author

Just in case you don't know. For freecad Netgen is bundled with smesh: https://github.com/trelau/SMESH/blob/master/.gitmodules#L1

I see. I had issues on some builds in loading the FEM examples and figured it was due to the CMake not finding netgen. I have confirmed that without netgen the builds operate correctly.

@oursland oursland closed this Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants