Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spacy Limits to match source #8

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

rxm7706
Copy link

@rxm7706 rxm7706 commented Apr 20, 2024

Source - https://github.com/huggingface/neuralcoref/blob/v4.0.0/setup.py#L233 spacy>=2.1.0"

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Old-style Python selectors (py27, py34, py35, py36) are deprecated. Instead, consider using the int py. For example: # [py>=36]. See lines [14]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@rxm7706
Copy link
Author

rxm7706 commented Apr 20, 2024

@conda-forge-admin, please rerender

@rxm7706
Copy link
Author

rxm7706 commented Apr 21, 2024

warnings

  • cc1plus: warning: command-line option '-Wno-strict-prototypes' is valid for C/ObjC but not for C++
  • 11 | #warning "Using deprecated NumPy API, disable it by #defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION"

Errors

  • object.h:133:33: error: lvalue required as increment operand
  • neuralcoref/neuralcoref.cpp:49340:112: error: 'PyTypeObject' {aka 'struct _typeobject'} has no member named 'tp_print'
  • neuralcoref/neuralcoref.cpp:53921:19: error: '_PyGen_Send' was not declared in this scope; did you mean '_PyGen_yf'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant