Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable osx_arm64 #32

Merged
merged 13 commits into from
Jan 31, 2024
Merged

Enable osx_arm64 #32

merged 13 commits into from
Jan 31, 2024

Conversation

RaulPPelaez
Copy link
Contributor

@RaulPPelaez RaulPPelaez commented Jan 19, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #25

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@RaulPPelaez
Copy link
Contributor Author

Same error as in #25, swig does not like the CPU
/bin/sh: /Users/runner/miniforge3/conda-bld/openmm-plumed_1705661581832/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/bin/swig: Bad CPU type in executable

@hadim
Copy link
Member

hadim commented Jan 19, 2024

Maybe try to add - swig # [build_platform != target_platform] in the build section?

@RaulPPelaez
Copy link
Contributor Author

No luck @hadim! Also tried to add this to conda-forge.yaml:

test_on_native_only: true

@hadim
Copy link
Member

hadim commented Jan 22, 2024

I tested locally with an M3 and the build works. It means it's indeed related to cross-compilation. But not sure what is causing this...

@RaulPPelaez
Copy link
Contributor Author

I reckon it is related with swig, a build tool, being downloaded for arm64, but we need it compiled for the build machine. Is there a way to download a package for the host architecture?

@peastman
Copy link
Contributor

Here's the corresponding section from the openmm-torch recipe, which successfully cross-compiles.

requirements:
  build:
    - python                                 # [build_platform != target_platform]
    - cross-python_{{ target_platform }}     # [build_platform != target_platform]
    - numpy >=1.19                           # [build_platform != target_platform]
    - swig <4.1                              # [build_platform != target_platform]
    - pytorch                                # [build_platform != target_platform]
    - pytorch =*={{ torch_proc_type }}*      # [build_platform != target_platform]
    - openmm >=8.0.0                         # [build_platform != target_platform]
    - {{ compiler('c') }}
    - {{ compiler('cxx') }}
    - {{ compiler('cuda') }}  # [cuda_compiler_version not in (undefined, 'None')]
    - {{ cdt('mesa-libgl-devel') }}  # [linux]
    - cmake
    - make

The one obvious difference is that it also includes OpenMM. Try adding

    - openmm >=8.1.0                         # [build_platform != target_platform]

Note that OpenMM-Plumed now requires 8.1 or later

@RaulPPelaez
Copy link
Contributor Author

I wonder why the same does not work here as in OpenMM-Torch....

@RaulPPelaez
Copy link
Contributor Author

omg, I fixed arm but broke the other one -.-

@RaulPPelaez
Copy link
Contributor Author

@conda-forge-admin, please rerender

@RaulPPelaez
Copy link
Contributor Author

Looks like I pulled it off!
@hadim Would you please review?

@hadim
Copy link
Member

hadim commented Jan 31, 2024

I am not a maintainer but it looks good to me.

@RaulPPelaez
Copy link
Contributor Author

Oh right -.-
Thanks!

@RaulPPelaez RaulPPelaez merged commit 2ca18da into conda-forge:main Jan 31, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants