-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dual builds of libxml2 #197
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2023.12.08.16.50.53
this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust @hmaarrfk's judgement over what I did in #196, but looking at the build log on libxml2 2.11 + linux64, I see this:
"libpq-16.1-h33b98f1_7.conda": {
"recipe": {
"c_compiler": "gcc",
"c_compiler_version": "12",
"channel_targets": "conda-forge main",
"krb5": "1.21",
"openssl": "3",
"target_platform": "linux-64"
}
So it appears the libxml2 dependency is getting dropped here for libpq?
Oh, I also am of the opinion that |
The thing is that all the packages i removed have a line like that will ensure that the correct runtime dependency is added: So i think it is enough. |
this is the list of dependencies that is used to generate the hash. linux + libxml2 2.11
linux64 + libxml2 + 2.12
so as you can see, the hash is the exact same. I don't think this is such a problem since libpq doesn't depend on any subpackage. if it did, then I would be worried. In effect, we are building 2 x |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)