-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.0.1 #17
Update to 1.0.1 #17
Conversation
…da-forge-pinning 2020.10.16.18.51.08
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/prettytable, this PR is ready for review. |
cc @hugovk. |
I'm not very familiar with conda-forge, but the updated URL and dependencies look right 👍 |
Ping @conda-forge/prettytable, could you please review this PR? |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/core, would it be possible to get this PR merged? From a quick search on github of the maintainer of this recipe (https://github.com/orgs/conda-forge/teams/prettytable/members), they don't seem to be active anymore on conda-forge. I have added myself to help with the maintenance of this recipe. @hugovk, would you like to be added as recipe maintainer too, since you are now maintaining prettytable? It would be useful if you could follow what is going on with this recipe! |
@conda-forge-admin, please rerender |
@conda-forge-admin please rerender |
Oops... @chrisburr was faster than me 😄 |
…da-forge-pinning 2020.11.03.00.15.30
You got a full commit in before I commented! |
Hi! This is the friendly automated conda-forge-webservice. |
Thanks! |
I'm not very familiar with Conda so not sure I'd be able to maintain this recipe. I am watching this repo though, and will comment if there's anything I spot. For example: PrettyTable 1.0.1 actually supports 2.7 and 3.5+, but fine if this recipe is only for 3.5+. It's very unlikely we'd fix anything for Python 2. The next PrettyTable release (probably 2.0.0) will be 3.6+. The EOL versions are already dropped in |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
@hugovk thanks! That kind of info is why having authors as maintainers is important. You don't need to worry about the conda details if you can every-now-and-them make comments like that. At the moment we are not building 2.7 and, while it would be nice to have it there for completeness, it won't get built. We need to watch out for the next release and update the Python constraint. |
Checklist
0
(if the version changed)conda-smithy
Close #16.