Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.0.1 #17

Merged
merged 9 commits into from
Nov 3, 2020
Merged

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Oct 18, 2020

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy
  • Ensured the license file is being packaged.

Close #16.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ericpre
Copy link
Member Author

ericpre commented Oct 18, 2020

@conda-forge/prettytable, this PR is ready for review.

@ericpre
Copy link
Member Author

ericpre commented Oct 18, 2020

cc @hugovk.

@hugovk
Copy link
Contributor

hugovk commented Oct 18, 2020

I'm not very familiar with conda-forge, but the updated URL and dependencies look right 👍

@ericpre
Copy link
Member Author

ericpre commented Oct 28, 2020

Ping @conda-forge/prettytable, could you please review this PR?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • noarch: python recipes are recommended to have a lower bound on minimum python bound. This recommendation will become requirement in a future version.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ericpre
Copy link
Member Author

ericpre commented Nov 3, 2020

@conda-forge/core, would it be possible to get this PR merged?

From a quick search on github of the maintainer of this recipe (https://github.com/orgs/conda-forge/teams/prettytable/members), they don't seem to be active anymore on conda-forge. I have added myself to help with the maintenance of this recipe.

@hugovk, would you like to be added as recipe maintainer too, since you are now maintaining prettytable? It would be useful if you could follow what is going on with this recipe!

@chrisburr
Copy link
Member

@conda-forge-admin, please rerender

@ocefpaf
Copy link
Member

ocefpaf commented Nov 3, 2020

@conda-forge-admin please rerender

@ocefpaf
Copy link
Member

ocefpaf commented Nov 3, 2020

Oops... @chrisburr was faster than me 😄

recipe/meta.yaml Outdated Show resolved Hide resolved
@chrisburr
Copy link
Member

Oops... @chrisburr was faster than me 😄

You got a full commit in before I commented!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2020

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@chrisburr chrisburr added the automerge Merge the PR when CI passes label Nov 3, 2020
@ericpre
Copy link
Member Author

ericpre commented Nov 3, 2020

Thanks!

@hugovk
Copy link
Contributor

hugovk commented Nov 3, 2020

I'm not very familiar with Conda so not sure I'd be able to maintain this recipe. I am watching this repo though, and will comment if there's anything I spot. For example:

PrettyTable 1.0.1 actually supports 2.7 and 3.5+, but fine if this recipe is only for 3.5+. It's very unlikely we'd fix anything for Python 2.

The next PrettyTable release (probably 2.0.0) will be 3.6+. The EOL versions are already dropped in master.

@github-actions github-actions bot merged commit 62b5d8a into conda-forge:master Nov 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2020

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@ocefpaf
Copy link
Member

ocefpaf commented Nov 3, 2020

I'm not very familiar with Conda so not sure I'd be able to maintain this recipe. I am watching this repo though, and will comment if there's anything I spot. For example:

PrettyTable 1.0.1 actually supports 2.7 and 3.5+, but fine if this recipe is only for 3.5+. It's very unlikely we'd fix anything for Python 2.

The next PrettyTable release (probably 2.0.0) will be 3.6+. The EOL versions are already dropped in master.

@hugovk thanks! That kind of info is why having authors as maintainers is important. You don't need to worry about the conda details if you can every-now-and-them make comments like that. At the moment we are not building 2.7 and, while it would be nice to have it there for completeness, it won't get built. We need to watch out for the next release and update the Python constraint.

@hugovk hugovk mentioned this pull request Nov 3, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants