Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be a bigger operation I fear - just opening this PR as a status update for now. Protobuf removed the usual
setup.py
approach, and we now either need to deal with the PyPI sources (harder to patch) or build with bazel.Also, the new way to build python from source seems to just rebuild a lot of stuff we already have in libprotobuf (e.g.
utf8_range
), and more importantly, alsoupb
, which is also being vendored by grpc, causing potential clashes there. I had tried to avoid this in protocolbuffers/protobuf#12927 but to no avail (c.f. also #170).The C++ backend is also removed, so I guess it's not even possible anymore to build atop of
libprotobuf
.