Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recipe to point to Paolo Herrera's official site #1

Closed
wants to merge 2 commits into from

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Mar 14, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

I was ready to create a feedstock for pyevtk when I realized to my amazement that someone had done so already! @renefritze, thank you very much for getting this started and for maintaining a mirror repo.

However, I've been in touch with @paulo-herrera and asked him to make an official v1.1.1 tag. In the process, he has decided to move the official site from BitBucket to GitHub. This should mean there is no longer a need to maintain the mirror repo at https://github.com/pyscience-projects/pyevtk (indeed, doing so could lead to confusion). I'll post an issue there as well.

@paulo-herrera also asked me to update the conda-forge feedstock to point to this new site. In the process, I needed to make a small patch (because README.txt was renamed to README.md but updates were not made to the MANIFEST and setup.py until after the v1.1.1 tag).

There is no longer a need to include the LICENSE or test in the recipe as they are part of the package, so I have removed them. I decided to run the full suite of examples as tests, since they are all extremely fast.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • There are too few lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xylar
Copy link
Contributor Author

xylar commented Mar 14, 2019

@renefritze, I hope you will be okay with me adding myself as a maintainer. I also hope you will not find me too pushy having made such a substantial revision to this feedstock. I really do appreciate the work you've put into it.

My colleagues and I use EVTK quite a lot to convert our model output to VTK format for visualization in ParaView, so we are really excited to have a package on conda-forge to use, rather than maintaining our own recipe on our own anaconda channel.

@xylar
Copy link
Contributor Author

xylar commented Mar 14, 2019

@conda-forge-admin, please rerender

@xylar
Copy link
Contributor Author

xylar commented Mar 14, 2019

@conda-forge-admin, please rerender

@xylar
Copy link
Contributor Author

xylar commented Mar 14, 2019

Similarly to conda-forge/python-slugify-feedstock#12, Appveyor shouldn't be running here because this is a noarch feedstock. I wonder what has gone wrong here.

Nevertheless, I think it is safe to merge.

@xylar
Copy link
Contributor Author

xylar commented Mar 15, 2019

I'm closing this for now, based on the discussion in pyscience-projects/pyevtk#7

@xylar xylar closed this Mar 15, 2019
@xylar xylar deleted the point_to_official_repo branch March 15, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants