Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.1.3 #1

Merged
merged 1 commit into from Nov 19, 2018
Merged

Bump to 1.1.3 #1

merged 1 commit into from Nov 19, 2018

Conversation

hadim
Copy link
Member

@hadim hadim commented Nov 18, 2018

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hadim
Copy link
Member Author

hadim commented Nov 18, 2018

@hanslovsky
Copy link
Contributor

Is there a specific reason to use the commit hash over the tag?

@hadim
Copy link
Member Author

hadim commented Nov 18, 2018

Because I think you cannot use tags on conda build recipe or at least I couldn't find it on the documentation.

@hanslovsky
Copy link
Contributor

You can, for example. Maybe we should switch to download the tar ball from the release (instead of checking out the source), anyway. Numpy, for example, does that. I will add suggestions to the code.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hadim
Copy link
Member Author

hadim commented Nov 18, 2018

Ok, I didn't know it was possible. I switched to numpy-styled to download the tarball.

Feel free to merge once CIs are happy.

@hanslovsky
Copy link
Contributor

Thanks @hadim I will wait until all the checks complete and then I will merge.

@hanslovsky hanslovsky merged commit 555ebe3 into conda-forge:master Nov 19, 2018
@hadim hadim deleted the 1.1.3 branch November 19, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants