Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: testing 1.4.3 #14

Merged
merged 6 commits into from
Jul 4, 2020

Conversation

stuarteberg
Copy link
Contributor

This PR tests the latest git rev of pyspice, which isn't tagged yet.
See #13

Checklist

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@stuarteberg
Copy link
Contributor Author

stuarteberg commented May 29, 2020

Here's the status of this test:

  1. Linux passes.

  2. Mac fails, but it's not a "real" failure. It fails due to some obscure git error related to unicode names. It will not fail in a "real" build, since those don't use a git_url source. (See note below.)

  3. Windows fails. Apparently pyspice-post-installation --check-install is failing with no error message -- just a bad exit code. I have no idea why, or even how this can happen without printing an error. I'm at a loss here.


Note about the Mac unicode failure:

This problem is not specific to conda-forge. Any Mac user with a recent version of git will encounter the following error when they clone the PySpice repo and run git status:

fatal: iconv_open(UTF-8,UTF-8-MAC) failed, but needed:
    precomposed unicode is not supported.
    If you want to use decomposed unicode, run
    "git config core.precomposeunicode false"

I called git config core.precomposeunicode false as suggested by the error message, and the problem disappeared. I guess all Mac users must do that when cloning PySpice.

What's the cause? Apparently something weird can happen when transferring files with non-ASCII names to/from the Mac filesystem. The PySpice repo contains two files with a non-ascii character (é):

examples/fundamental-laws/m4/thévenin-norton-theorem.m4
examples/fundamental-laws/thévenin-norton-theorem.py

I am not knowledgeable on the subject of "precomposed" vs. "decomposed" unicode, but here are some possible solutions:

  • Change those two file names
  • Maybe there is some way to fix the repo without changing the file names.
  • Add a warning to Mac users in the README

Again, this is not a problem for our conda-forge recipe in general, since we will normally build from a tarball, not from git.

@stuarteberg
Copy link
Contributor Author

stuarteberg commented Jun 1, 2020

@FabriceSalvaire OK, I fixed the issue on Windows. (It's related to conda/conda-build#3965.)

As mentioned above, the Mac problem is not a "real" problem. So I think this PR demonstrates that we'll be ready to publish conda packages for v1.4.3 whenever you tag it in the PySpice repo.

@FabriceSalvaire
Copy link
Contributor

@stuarteberg looks good ! I got a Windows machine to test ! but must read conda-forge doc ...

@stuarteberg
Copy link
Contributor Author

I got a Windows machine to test !

Since this is just a PR and has not yet been merged to master, the package is not uploaded to anaconda.org. There is no convenient way to test it.

But I have just rebuilt this recipe locally, and uploaded it to my personal channel for you to test:

conda install -c stuarteberg pyspice=1.4.3b0=pr14_0

I won't be able to do that frequently, but maybe that's enough for a basic evaluation of this recipe so far.

FabriceSalvaire added a commit that referenced this pull request Jul 4, 2020
@FabriceSalvaire FabriceSalvaire merged commit bdc2739 into conda-forge:master Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants